Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

recognitionService.recognize without limit parameter results in malformed url #33

Open
No3x opened this issue May 19, 2022 · 2 comments

Comments

@No3x
Copy link

No3x commented May 19, 2022

Describe the bug
If you call recognize without limit parameter the url is not valid and a 400 is returned from the REST API.

To Reproduce

try {
    const result = await recognitionService.recognize(path_toTestImage, {
      face_plugins: 'landmarks,gender,age',
      det_prob_threshold: 0.95,
      status: true
    });
} catch (e) {
    console.error('Error while recognize' + e.message);
    console.error(e.config.url); // <-- comes here. not good
}

Prints
http://localhost:8000/api/v1/recognition/recognize?det_prob_threshold=0.95?face_plugins=landmarks,gender,age?status=true

Expected behavior
If I do not pass limit it should use a default or build a valid url.
Should be
http://localhost:8000/api/v1/recognition/recognize?det_prob_threshold=0.95&face_plugins=landmarks,gender,age&status=true

Maybe other webservers/backends do not care but I use the docker-compose version from https://github.com/exadel-inc/CompreFace/releases/tag/v1.0.0

@No3x
Copy link
Author

No3x commented May 19, 2022

I did another check and it seems like it can be reproduced also with

const result = await recognitionService.recognize(path_toTestImage, {
      det_prob_threshold: 0.95,
      status: true
});

http://localhost:8000/api/v1/recognition/recognize?det_prob_threshold=0.95?status=true

Adding limit fixes it

const result = await recognitionService.recognize(path_toTestImage, {
      limit: 0,
      det_prob_threshold: 0.95,
      status: true
});

@smchedlidze826
Copy link
Collaborator

We are working on this issue and it will be fixed in the next release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants