Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validating US numbers with area code 689 #56

Closed
NicolayD opened this issue May 26, 2022 · 1 comment
Closed

Validating US numbers with area code 689 #56

NicolayD opened this issue May 26, 2022 · 1 comment

Comments

@NicolayD
Copy link

NicolayD commented May 26, 2022

Hi, thank you for the helpful library you've built.

I stumbled upon a problem validating US phone numbers with area code 689 which seems to be a fairly new (several years old) phone area code for somewhere in Florida, at least according to this article.

When I test at https://libphonenumber.appspot.com with a number such as +16894023931 it validates it successfully, but this returns false:

> {:ok, parsed_phone} = ExPhoneNumber.parse("+16894023931", "US")
> ExPhoneNumber.is_valid_number?(parsed_phone)
false
@szymon-jez
Copy link
Member

Thank you very much for your kind words.

Work is being done (regrettably it staled...) in #43 to address such issues like yours by updating the metadata that is used to determine if a number is valid or not etc.

Closing this issue as it will be solved by #43.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants