Name the "magic numbers"

[eximius313]

BerTlvBuilder contains a lot of "magic numbers" (0x80, 0x81, 0x100 and so on). What are they? Could you make them constant?

    private void fillLength(byte[] aBuffer, int aOffset, int aLength) {

        if(aLength < 0x80) {
            aBuffer[aOffset] = (byte) aLength;

        } else if (aLength <0x100) {
            aBuffer[aOffset] = (byte) 0x81;
            aBuffer[aOffset+1] = (byte) aLength;

        } else if( aLength < 0x10000) {

            aBuffer[aOffset]   = (byte) 0x82;
            aBuffer[aOffset+1] = (byte) (aLength / 0x100);
            aBuffer[aOffset+2] = (byte) (aLength % 0x100);

        } else if( aLength < 0x1000000 ) {
            aBuffer[aOffset]   = (byte) 0x83;
            aBuffer[aOffset+1] = (byte) (aLength / 0x10000);
            aBuffer[aOffset+2] = (byte) (aLength / 0x100);
            aBuffer[aOffset+3] = (byte) (aLength % 0x100);
        } else {
            throw new IllegalStateException("length ["+aLength+"] out of range (0x1000000)");
        }
    }

[martinpaljak]

These are constants.

[eximius313]

Great, and what are their names/meanings?

[eximius313]

by constant I meant:

static final int FIELD_DELIMITER = 0x80

[martinpaljak]

What would that add? Did you read TLV specs? Why is "CONSTANT_100" better than "100" ?

[eximius313]

"100" is a value. But in the code it has a meaning. And the name should express that meaning.
For example - why it's 0x80 and not 0x83 or 0x42? ;)