Fix duplications report metrics when report run multiple times. (#1230)

src/evidently/report/report.py

@@ -101,6 +101,7 @@ def run(
             self.timestamp = self._timestamp
         else:
             self.timestamp = timestamp or datetime.now()
+        self._first_level_metrics = []
         self._inner_suite.reset()
         self._inner_suite.set_engine(PythonEngine() if engine is None else engine())
 

tests/report/test_report.py

@@ -2,7 +2,6 @@
 from typing import List
 
 import pandas as pd
-import pytest
 
 from evidently.base_metric import InputData
 from evidently.base_metric import Metric
@@ -35,14 +34,9 @@ def render_html(self, obj) -> List[BaseWidgetInfo]:
         raise NotImplementedError
 
 
-@pytest.fixture
-def report():
+def test_as_dict():
     report = Report(metrics=[MockMetric()])
     report.run(reference_data=pd.DataFrame(), current_data=pd.DataFrame())
-    return report
-
-
-def test_as_dict(report: Report):
     assert report.as_dict() == {"metrics": [{"metric": "MockMetric", "result": {"value": "a"}}]}
     include_series = report.as_dict(include={"MockMetric": {"value", "series"}})["metrics"][0]["result"]
     assert "series" in include_series
@@ -54,7 +48,20 @@ def test_as_dict(report: Report):
     assert "distribution" in include_render
 
 
-def test_json(report: Report):
+def test_json():
+    report = Report(metrics=[MockMetric()])
+    report.run(reference_data=pd.DataFrame(), current_data=pd.DataFrame())
+    default = json.loads(report.json())["metrics"]
+    assert default == [{"metric": "MockMetric", "result": {"value": "a"}}]
+
+    include_series = json.loads(report.json(include={"MockMetric": {"value", "series"}}))["metrics"]
+    assert include_series == [{"metric": "MockMetric", "result": {"value": "a", "series": [0]}}]
+
+
+def test_multirun_json():
+    report = Report(metrics=[MockMetric()])
+    report.run(reference_data=pd.DataFrame(), current_data=pd.DataFrame())
+    report.run(reference_data=pd.DataFrame(), current_data=pd.DataFrame())  # 2nd run to check that report isn't changed
     default = json.loads(report.json())["metrics"]
     assert default == [{"metric": "MockMetric", "result": {"value": "a"}}]