Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search for groups of granules and convert them. #79

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

evetion
Copy link
Owner

@evetion evetion commented Mar 30, 2024

Continuing from #78

Changes:

  • (breaking for unreleased master branch) search(granule) now return a single granule only with the online url (previously did search based on the mission/product of the provided granule, yielding many results)

Adds:

  • search(granules), returning online urls for multiple granules
  • search(granule, product), returns a single (online) granule for the given product, with the rest derived from the original granule
  • search(granules, product), same as above for multiple granules.

Rationale

Local granules can be corrupt, so retrieving the online url to redownload is very useful. On top of that, I tend to want both the ATL03 and ATL08 versions of a granule. At the moment this requires multiple searches (with the same bbox), but this yields slightly different results (ATL03 tends to yield more granules than ATL08). Now you can do search(granules, :ATL03) with a list of ATL08 granules.

Note that I changed the HTTP search method to POST to allow for a large body of ids, that otherwise don't fit as a single url (GET).

@evetion
Copy link
Owner Author

evetion commented Oct 10, 2024

@alex-s-gardner Did you use the search(granule) functionality?

@evetion evetion marked this pull request as ready for review October 10, 2024 20:55
Copy link
Collaborator

@alex-s-gardner alex-s-gardner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@alex-s-gardner
Copy link
Collaborator

@alex-s-gardner Did you use the search(granule) functionality?

You would think so but I can't seem to find any instances in my code.. but now I can keep my eyes out for search errors.

@evetion evetion merged commit 2f648c7 into master Oct 11, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants