DEVPROD-12451 Update last communication time during host reprovisioning #8507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEVPROD-12451
Description
When un-quaranting a static host that has been quarantined for a while, sometimes it can get immediately re-quarantined because of a race:
LastCommunicatedTimefrom too long ago, before the re-provisioning job (which gets queued immediately when the host is un-quarantined) can updateLastCommunicatedTime.This change updates a host's
LastCommunicatedTimeright at the time it gets marked as reprovisioning to fix this.Testing
Added a check to an existing unit test