DEVPROD-7663: Add grip statements to track Image Visibility API errors #8488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ablack12
reviewed
Nov 20, 2024
ablack12
approved these changes
Nov 20, 2024
There was a problem hiding this comment.
Quick question -- do you know if we're already logging errors related to this at the error level? In that case, I think we should reduce all of these logs to the debug level -- otherwise, we're double counting errors, which can be annoying for our elevated error rate alert.
thirdparty/runtime_environments.go
Outdated
| } | ||
| toolchains := &APIToolchainResponse{} | ||
| if err := gimlet.GetJSON(resp.Body, &toolchains); err != nil { | ||
| grip.Error(message.WrapError(err, message.Fields{ | ||
| "message": "parsing response from image visibility API", | ||
| "reason": "runtime environments API alerting", |
There was a problem hiding this comment.
actually tiny nit -- since this is consistent, I'd recommend making this a constant at the top of the file, like this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEVPROD-7663
Description
Add grip errors for:
This will be used to configure a new Splunk alert.
Tagging app because I think you can tell me better on how grip alerts should look like 😅
Testing