DEVPROD-12824 Reset ~/.git-credentials between tasks #8482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kimchelly
approved these changes
Nov 22, 2024
|
|
||
| logger.Infof("Clearing git credentials.") | ||
| globalGitCredentialsPath := filepath.Join(a.opts.HomeDirectory, ".git-credentials") | ||
| if _, err := os.Stat(globalGitCredentialsPath); os.IsNotExist(err) { |
There was a problem hiding this comment.
nit: you can use os.RemoveAll instead of os.Remove to have it ignore errors when the file doesn't exist. That avoids having to specifically stat the file. (same with the logic above)
There was a problem hiding this comment.
I think Remove() plus the error check is safer here because we expect it to be a fileName and not have any children
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEVPROD-12824
Description
This cleans up the default git-credential-store credential helper path.
Testing
Added to existing tests
Documentation
Added