DEVPROD-12194 update PR description #8473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malikchaya2
reviewed
Nov 11, 2024
.github/pull_request_template.md
Outdated
Comment on lines
10
to
12
| Remember to add or edit docs in the docs/ directory if relevant. | ||
| <!-- If you're only updating docs, create a patch for the Pine tasks to ensure our changes are compatible, | ||
| if you're making any structural changes (for example, adding links or new pages)--> |
There was a problem hiding this comment.
I understand
"If you're only updating docs, create a patch for the Pine tasks to ensure our changes are compatible"
but I don't understand this part:
"if you're making any structural changes (for example, adding links or new pages)"
What should be done in this case?
There was a problem hiding this comment.
Ah i meant you only need to create a patch if you're making actual structural changes. this is poorly worded ,let me tweak
malikchaya2
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEVPROD-12194
Description
Make a note to test pine for markdown only changes that could break it.