From c5ff83db40d25d45889b8733bf6a72a79eee7c90 Mon Sep 17 00:00:00 2001
From: Innocent-akim <gentilakili98@gmail.com>
Date: Sat, 30 Nov 2024 10:26:52 +0200
Subject: [PATCH 1/6] Fix: handle timesheet update with precise time ranges and
 billing information

---
 .../[memberId]/components/AddTaskModal.tsx    |  64 ++++++---
 .../[memberId]/components/EditTaskModal.tsx   | 121 ++++++++++++------
 .../[locale]/timesheet/[memberId]/page.tsx    |   2 +-
 .../hooks/features/useTimelogFilterOptions.ts |  10 +-
 apps/web/app/interfaces/timer/ITimerLog.ts    |  12 +-
 apps/web/lib/components/combobox/index.tsx    |   5 +-
 .../manual-time/manage-member-component.tsx   |   7 +-
 7 files changed, 148 insertions(+), 73 deletions(-)

diff --git a/apps/web/app/[locale]/timesheet/[memberId]/components/AddTaskModal.tsx b/apps/web/app/[locale]/timesheet/[memberId]/components/AddTaskModal.tsx
index 3a13f5688..2f38dda15 100644
--- a/apps/web/app/[locale]/timesheet/[memberId]/components/AddTaskModal.tsx
+++ b/apps/web/app/[locale]/timesheet/[memberId]/components/AddTaskModal.tsx
@@ -60,9 +60,9 @@ export function AddTaskModal({ closeModal, isOpen }: IAddTaskModalProps) {
             closeModal={closeModal}
             title={'+ Add Time Entry'}
             showCloseIcon
-            className="bg-light--theme-light dark:bg-dark--theme-light p-5 rounded-xl w-full md:w-40 md:min-w-[30rem] justify-start h-[auto] overflow-y-auto"
+            className="bg-light--theme-light dark:bg-dark--theme-light p-5 rounded-xl w-full md:w-40 md:min-w-[32rem] justify-start h-[auto]"
             titleClass="font-bold flex justify-start w-full">
-            <div className="flex flex-col w-full gap-4 justify-start overflow-y-auto">
+            <div className="flex flex-col w-full gap-4 justify-start md:w-40 md:min-w-[32rem] p-4">
                 <div className=" w-full mr-[4%]">
                     <label className="block text-[#282048] dark:text-gray-400 font-medium mb-1">
                         {t('sidebar.TASKS')}
@@ -207,7 +207,7 @@ const ShiftTimingSelect = ({ label, timeOptions, placeholder, className, onChang
                         <SelectItem
                             key={time}
                             value={time}
-                            className="hover:bg-primary focus:bg-primary hover:text-white px-2 py-1 cursor-pointer"
+                            className="hover:bg-primary focus:bg-primary hover:text-white  py-1 cursor-pointer"
                         >
                             {time}
                         </SelectItem>
@@ -236,23 +236,30 @@ const OptimizedAccordion = ({ dateRange, handleFromChange, timeOptions, t }: {
         const [hours, minutes] = time.split(':').map(Number);
         return hours * 60 + minutes;
     };
+    const convertToMinutesHour = (time: string): number => {
+        const [hourMinute, period] = time.split(' ');
+        const [hours, minutes] = hourMinute.split(':').map(Number);
 
-    const calculateTotalHours = React.useCallback((start: string, end: string): string => {
-        if (!start || !end) return '00:00h';
-
-        const startMinutes = convertToMinutes(start);
-        const endMinutes = convertToMinutes(end);
-
-        const totalMinutes = endMinutes >= startMinutes
-            ? endMinutes - startMinutes
-            : 1440 - startMinutes + endMinutes;
-
-        const hours = Math.floor(totalMinutes / 60);
-        const minutes = totalMinutes % 60;
-        return `${String(hours).padStart(2, '0')}:${String(minutes).padStart(2, '0')}h`;
-    }, []);
+        let totalMinutes = (hours % 12) * 60 + minutes;
+        if (period === 'PM') totalMinutes += 720;
 
+        return totalMinutes;
+    }
 
+    const calculateTotalHoursHour = React.useCallback(
+        (start: string, end: string): string => {
+            if (!start || !end) return '00:00h';
+            const startMinutes = convertToMinutesHour(start);
+            const endMinutes = convertToMinutesHour(end);
+            const totalMinutes = endMinutes >= startMinutes
+                ? endMinutes - startMinutes
+                : 1440 - startMinutes + endMinutes;
+            const hours = Math.floor(totalMinutes / 60);
+            const minutes = totalMinutes % 60;
+            return `${String(hours).padStart(2, '0')}:${String(minutes).padStart(2, '0')}h`;
+        },
+        []
+    );
 
     const handleAddShift = () => {
         setShifts([...shifts,
@@ -264,26 +271,43 @@ const OptimizedAccordion = ({ dateRange, handleFromChange, timeOptions, t }: {
         setShifts(updatedShifts);
     };
 
+
     const handleShiftChange = (index: number, field: keyof Shift, value: string) => {
         const updatedShifts = [...shifts];
         updatedShifts[index][field] = value;
 
         if (field === 'startTime' || field === 'endTime') {
             const { startTime, endTime } = updatedShifts[index];
-            updatedShifts[index].totalHours = calculateTotalHours(startTime, endTime);
+
+            // Validation des données
+            if (!startTime || !endTime) return;
+
+            if (convertToMinutes(startTime) >= convertToMinutes(endTime)) {
+                alert('L’heure de début doit être inférieure à l’heure de fin.');
+                return;
+            }
+            updatedShifts[index].totalHours = calculateTotalHoursHour(startTime, endTime);
+            // Détection des chevauchements
             const isOverlapping = shifts.some((shift, i) => {
                 if (i === index || !shift.startTime || !shift.endTime) return false;
+
                 const currentStart = convertToMinutes(startTime);
                 const currentEnd = convertToMinutes(endTime);
                 const shiftStart = convertToMinutes(shift.startTime);
                 const shiftEnd = convertToMinutes(shift.endTime);
-                return (currentStart >= shiftStart && currentStart < shiftEnd) ||
-                    (currentEnd > shiftStart && currentEnd <= shiftEnd);
+
+                return (
+                    (currentStart < shiftEnd && currentEnd > shiftStart) ||
+                    (currentStart === shiftStart && currentEnd === shiftEnd)
+                );
             });
+
             if (isOverlapping) {
+                alert('Le shift modifié chevauche un autre shift existant.');
                 return;
             }
         }
+
         setShifts(updatedShifts);
     };
 
diff --git a/apps/web/app/[locale]/timesheet/[memberId]/components/EditTaskModal.tsx b/apps/web/app/[locale]/timesheet/[memberId]/components/EditTaskModal.tsx
index 3c19327df..79661a52b 100644
--- a/apps/web/app/[locale]/timesheet/[memberId]/components/EditTaskModal.tsx
+++ b/apps/web/app/[locale]/timesheet/[memberId]/components/EditTaskModal.tsx
@@ -2,7 +2,7 @@ import { Modal, statusColor } from "@/lib/components";
 import { IoMdArrowDropdown } from "react-icons/io";
 import { FaRegClock } from "react-icons/fa";
 import { DatePickerFilter } from "./TimesheetFilterDate";
-import { useState } from "react";
+import { FormEvent, useCallback, useState } from "react";
 import { useTranslations } from "next-intl";
 import { clsxm } from "@/app/utils";
 import { Item, ManageOrMemberComponent, getNestedValue } from "@/lib/features/manual-time/manage-member-component";
@@ -10,6 +10,8 @@ import { useTeamTasks } from "@/app/hooks";
 import { CustomSelect, TaskNameInfoDisplay } from "@/lib/features";
 import { statusTable } from "./TimesheetAction";
 import { TimesheetLog } from "@/app/interfaces";
+import { secondsToTime } from "@/app/helpers";
+import { useTimesheet } from "@/app/hooks/features/useTimesheet";
 
 export interface IEditTaskModalProps {
 	isOpen: boolean;
@@ -19,34 +21,40 @@ export interface IEditTaskModalProps {
 export function EditTaskModal({ isOpen, closeModal, dataTimesheet }: IEditTaskModalProps) {
 	const { activeTeam } = useTeamTasks();
 	const t = useTranslations();
-	// const [dateRange, setDateRange] = useState<{ from: Date | null }>({
-	// 	from: new Date(),
-	// });
-	// const [endTime, setEndTime] = useState<string>('');
-	// const [startTime, setStartTime] = useState<string>('');
-	// const [isBillable, setIsBillable] = useState<boolean>(dataTimesheet.isBillable);
-	// const [notes, setNotes] = useState('');
+	const { updateTimesheet } = useTimesheet({})
 
-	const [dateRange, setDateRange] = useState<{ from: Date | null }>({
-		from: dataTimesheet.timesheet?.startedAt ? new Date(dataTimesheet.timesheet.startedAt) : new Date(),
+	const [dateRange, setDateRange] = useState<{ date: Date | null }>({
+		date: dataTimesheet.timesheet?.startedAt ? new Date(dataTimesheet.timesheet.startedAt) : new Date(),
 	});
-	const [endTime, setEndTime] = useState<string>(
-		dataTimesheet.timesheet?.stoppedAt
-			? new Date(dataTimesheet.timesheet.stoppedAt).toLocaleTimeString('en-US', { hour12: false }).slice(0, 5)
-			: ''
-	);
-	const [startTime, setStartTime] = useState<string>(
-		dataTimesheet.timesheet?.startedAt
-			? new Date(dataTimesheet.timesheet.startedAt).toLocaleTimeString('en-US', { hour12: false }).slice(0, 5)
-			: ''
-	);
-	const [isBillable, setIsBillable] = useState<boolean>(dataTimesheet.isBillable);
-	const [notes, setNotes] = useState<string>('');
+
+	const { h: hours, m: minutes } = secondsToTime(dataTimesheet.timesheet.duration);
+	const [timeRange, setTimeRange] = useState<{ startTime: string; endTime: string }>({
+		startTime: '',
+		endTime: '',
+	});
+
+
+
+	const updateTime = (key: 'startTime' | 'endTime', value: string) => {
+		setTimeRange(prevState => ({
+			...prevState,
+			[key]: value,
+		}));
+	};
+	const [timesheetData, setTimesheetData] = useState({
+		isBillable: dataTimesheet.isBillable,
+		projectId: dataTimesheet?.project?.id || '',
+		notes: dataTimesheet.description || '',
+	});
+
 	const memberItemsLists = {
 		Project: activeTeam?.projects as [],
 	};
 	const handleSelectedValuesChange = (values: { [key: string]: Item | null }) => {
-		// Handle value changes
+		setTimesheetData((prev) => ({
+			...prev,
+			projectId: values['Project']?.id,
+		}));
 	};
 	const selectedValues = {
 		Teams: null,
@@ -55,6 +63,29 @@ export function EditTaskModal({ isOpen, closeModal, dataTimesheet }: IEditTaskMo
 		// Handle field changes
 	};
 
+	const handleUpdateSubmit = useCallback(async (e: FormEvent<HTMLFormElement>) => {
+		e.preventDefault();
+		const startedAt = new Date(dateRange.date ?? new Date());
+		const stoppedAt = new Date(dateRange.date ?? new Date());
+		const [startHours, startMinutes] = timeRange.startTime.split(':').map(Number);
+		startedAt.setHours(startHours, startMinutes);
+		const [endHours, endMinutes] = timeRange.endTime.split(':').map(Number);
+		stoppedAt.setHours(endHours, endMinutes);
+		await updateTimesheet({
+			id: dataTimesheet.timesheetId,
+			isBillable: timesheetData.isBillable,
+			employeeId: dataTimesheet.employeeId,
+			logType: dataTimesheet.logType,
+			source: dataTimesheet.source,
+			startedAt: startedAt,
+			stoppedAt: stoppedAt,
+			tenantId: dataTimesheet.tenantId,
+			organizationId: dataTimesheet.organizationId,
+			description: timesheetData.notes,
+			projectId: timesheetData.projectId,
+		});
+	}, [dateRange, timeRange, timesheetData, dataTimesheet, updateTimesheet]);
+
 	const fields = [
 		{
 			label: t('sidebar.PROJECTS'),
@@ -67,7 +98,7 @@ export function EditTaskModal({ isOpen, closeModal, dataTimesheet }: IEditTaskMo
 	];
 
 	const handleFromChange = (fromDate: Date | null) => {
-		setDateRange((prev) => ({ ...prev, from: fromDate }));
+		setDateRange((prev) => ({ ...prev, date: fromDate }));
 	};
 	return (
 		<Modal
@@ -77,7 +108,7 @@ export function EditTaskModal({ isOpen, closeModal, dataTimesheet }: IEditTaskMo
 			title={'Edit Task'}
 			className="bg-light--theme-light dark:bg-dark--theme-light p-5 rounded-xl w-full md:w-40 md:min-w-[30rem] justify-start h-[auto]"
 			titleClass="font-bold flex justify-start w-full">
-			<div className="flex flex-col w-full">
+			<form onSubmit={handleUpdateSubmit} className="flex flex-col w-full">
 				<div className="flex flex-col border-b border-b-slate-100 dark:border-b-gray-700">
 					<TaskNameInfoDisplay
 						task={dataTimesheet.task}
@@ -98,7 +129,7 @@ export function EditTaskModal({ isOpen, closeModal, dataTimesheet }: IEditTaskMo
 						<span className="text-[#282048] dark:text-gray-500 ">{t('dailyPlan.TASK_TIME')}</span>
 						<div className="flex items-center gap-x-2 ">
 							<FaRegClock className="text-[#30B366]" />
-							<span>08:10h</span>
+							<span>{hours}:{minutes} h</span>
 						</div>
 					</div>
 					<div className="flex items-center w-full">
@@ -111,8 +142,8 @@ export function EditTaskModal({ isOpen, closeModal, dataTimesheet }: IEditTaskMo
 								aria-label="Start time"
 								aria-describedby="start-time-error"
 								type="time"
-								value={startTime}
-								onChange={(e) => setStartTime(e.target.value)}
+								value={timeRange.startTime}
+								onChange={(e) => updateTime("startTime", e.target.value)}
 								className="w-full p-1 border font-normal border-slate-300 dark:border-slate-600 dark:bg-dark--theme-light rounded-md"
 								required
 							/>
@@ -128,8 +159,8 @@ export function EditTaskModal({ isOpen, closeModal, dataTimesheet }: IEditTaskMo
 								aria-label="End time"
 								aria-describedby="end-time-error"
 								type="time"
-								value={endTime}
-								onChange={(e) => setEndTime(e.target.value)}
+								value={timeRange.endTime}
+								onChange={(e) => updateTime('endTime', e.target.value)}
 								className="w-full p-1 border font-normal border-slate-300 dark:border-slate-600 dark:bg-dark--theme-light rounded-md"
 								required
 							/>
@@ -139,13 +170,14 @@ export function EditTaskModal({ isOpen, closeModal, dataTimesheet }: IEditTaskMo
 					<div>
 						<span className="block text-[#282048] dark:text-gray-500   mr-2">{t("manualTime.DATE")}</span>
 						<DatePickerFilter
-							date={dateRange.from}
+							date={dateRange.date}
 							setDate={handleFromChange}
 							label="Oct 01 2024"
 						/>
 					</div>
 					<div className="w-full flex flex-col">
 						<ManageOrMemberComponent
+							defaultValue={dataTimesheet?.project?.name ?? ""}
 							classNameTitle={'text-[#282048] dark:text-gray-500  '}
 							fields={fields}
 							itemsLists={memberItemsLists}
@@ -160,13 +192,19 @@ export function EditTaskModal({ isOpen, closeModal, dataTimesheet }: IEditTaskMo
 						<label className="text-[#282048] dark:text-gray-500   mr-12 capitalize">{t('pages.timesheet.BILLABLE.BILLABLE').toLowerCase()}</label>
 						<div className="flex items-center gap-3">
 							<ToggleButton
-								isActive={isBillable}
-								onClick={() => setIsBillable(true)}
+								isActive={timesheetData.isBillable}
+								onClick={() => setTimesheetData((prev) => ({
+									...prev,
+									isBillable: true,
+								}))}
 								label={t('pages.timesheet.BILLABLE.YES')}
 							/>
 							<ToggleButton
-								isActive={!isBillable}
-								onClick={() => setIsBillable(false)}
+								isActive={!timesheetData.isBillable}
+								onClick={() => setTimesheetData((prev) => ({
+									...prev,
+									isBillable: false,
+								}))}
 								label={t('pages.timesheet.BILLABLE.NO')}
 							/>
 						</div>
@@ -174,14 +212,17 @@ export function EditTaskModal({ isOpen, closeModal, dataTimesheet }: IEditTaskMo
 					<div className="w-full flex flex-col">
 						<span className="text-[#282048] dark:text-gray-400">{t('common.NOTES')}</span>
 						<textarea
-							value={notes}
-							onChange={(e) => setNotes(e.target.value)}
+							value={timesheetData.notes}
+							onChange={(e) => setTimesheetData((prev) => ({
+								...prev,
+								notes: e.target.value,
+							}))}
 							placeholder="Insert notes here..."
 							className={clsxm(
 								"bg-transparent focus:border-transparent focus:ring-2 focus:ring-transparent",
 								"placeholder-gray-300 placeholder:font-normal resize-none p-2 grow w-full",
 								"border border-gray-200 dark:border-slate-600 dark:bg-dark--theme-light rounded-md h-40 bg-[#FBB6500D]",
-								notes.trim().length === 0 && "border-red-500"
+								timesheetData.notes.trim().length === 0 && "border-red-500"
 							)}
 							maxLength={120}
 							minLength={0}
@@ -189,7 +230,7 @@ export function EditTaskModal({ isOpen, closeModal, dataTimesheet }: IEditTaskMo
 							required
 						/>
 						<div className="text-sm text-[#282048] dark:text-gray-500   text-right">
-							{notes.length}/{120}
+							{timesheetData.notes.length}/{120}
 						</div>
 					</div>
 					<div className="border-t border-t-gray-200 dark:border-t-gray-700 w-full"></div>
@@ -224,7 +265,7 @@ export function EditTaskModal({ isOpen, closeModal, dataTimesheet }: IEditTaskMo
 						</div>
 					</div>
 				</div>
-			</div>
+			</form>
 
 		</Modal>
 	)
diff --git a/apps/web/app/[locale]/timesheet/[memberId]/page.tsx b/apps/web/app/[locale]/timesheet/[memberId]/page.tsx
index a90e0378a..c65c98546 100644
--- a/apps/web/app/[locale]/timesheet/[memberId]/page.tsx
+++ b/apps/web/app/[locale]/timesheet/[memberId]/page.tsx
@@ -208,7 +208,7 @@ const TimeSheet = React.memo(function TimeSheetPage({ params }: { params: { memb
 	);
 });
 
-export default withAuthentication(TimeSheet, { displayName: 'TimeSheet' });
+export default withAuthentication(TimeSheet, { displayName: 'TimeSheet', showPageSkeleton: true });
 
 const ViewToggleButton: React.FC<ViewToggleButtonProps> = ({ mode, active, icon, onClick, t }) => (
 	<button
diff --git a/apps/web/app/hooks/features/useTimelogFilterOptions.ts b/apps/web/app/hooks/features/useTimelogFilterOptions.ts
index a8fdc2fd8..a79fcb1ad 100644
--- a/apps/web/app/hooks/features/useTimelogFilterOptions.ts
+++ b/apps/web/app/hooks/features/useTimelogFilterOptions.ts
@@ -19,11 +19,15 @@ export function useTimelogFilterOptions() {
     const generateTimeOptions = (interval = 15) => {
         const totalSlots = (24 * 60) / interval; // Total intervals in a day
         return Array.from({ length: totalSlots }, (_, i) => {
-            const hour = Math.floor((i * interval) / 60).toString().padStart(2, '0');
-            const minutes = ((i * interval) % 60).toString().padStart(2, '0');
-            return `${hour}:${minutes}`;
+            const totalMinutes = i * interval;
+            const hour24 = Math.floor(totalMinutes / 60);
+            const hour12 = hour24 % 12 || 12; // Convert to 12-hour format
+            const minutes = (totalMinutes % 60).toString().padStart(2, '0');
+            const period = hour24 < 12 ? 'AM' : 'PM'; // Determine AM/PM
+            return `${hour12.toString().padStart(2, '0')}:${minutes} ${period}`;
         });
     };
+
     const handleSelectRowTimesheet = (items: string) => {
         setSelectTimesheet((prev) => prev.includes(items) ? prev.filter((filter) => filter !== items) : [...prev, items])
     }
diff --git a/apps/web/app/interfaces/timer/ITimerLog.ts b/apps/web/app/interfaces/timer/ITimerLog.ts
index 09368bbad..b40955c4d 100644
--- a/apps/web/app/interfaces/timer/ITimerLog.ts
+++ b/apps/web/app/interfaces/timer/ITimerLog.ts
@@ -85,11 +85,11 @@ interface OrganizationContact extends BaseEntity, ImageEntity {
 }
 
 export interface TimesheetLog extends BaseEntity {
-    startedAt: string;
-    stoppedAt: string;
+    startedAt: string | Date;
+    stoppedAt: string | Date;
     editedAt: string | null;
-    logType: TimeLogType;
-    source: TimerSource;
+    logType: TimeLogType.MANUAL;
+    source: TimerSource.BROWSER;
     description: string;
     reason: string | null;
     isBillable: boolean;
@@ -117,8 +117,8 @@ export interface UpdateTimesheetStatus extends BaseEntity {
     keyboard: number;
     mouse: number;
     overall: number;
-    startedAt: string;
-    stoppedAt: string;
+    startedAt: string | Date;
+    stoppedAt: string | Date;
     approvedAt: string | null;
     submittedAt: string | null;
     lockedAt: string | null;
diff --git a/apps/web/lib/components/combobox/index.tsx b/apps/web/lib/components/combobox/index.tsx
index d0faacc2b..20fd6db83 100644
--- a/apps/web/lib/components/combobox/index.tsx
+++ b/apps/web/lib/components/combobox/index.tsx
@@ -18,6 +18,7 @@ interface ComboboxProps<T> {
 	className?: string;
 	popoverClassName?: string;
 	selectedItem?: T | null;
+	defaultValue?: string
 }
 
 export function CustomCombobox<T>({
@@ -31,7 +32,8 @@ export function CustomCombobox<T>({
 	onChangeValue,
 	className,
 	popoverClassName,
-	selectedItem = null
+	selectedItem = null,
+	defaultValue
 }: Readonly<ComboboxProps<T>>) {
 	const [open, setOpen] = React.useState(false);
 	const [value, setValue] = React.useState<T | null>(selectedItem);
@@ -88,6 +90,7 @@ export function CustomCombobox<T>({
 						<CommandGroup>
 							{items.map((item) => (
 								<CommandItem
+									defaultValue={defaultValue}
 									className="w-full dark:bg-dark--theme-light"
 									key={itemToValue(item)}
 									value={itemToValue(item)}
diff --git a/apps/web/lib/features/manual-time/manage-member-component.tsx b/apps/web/lib/features/manual-time/manage-member-component.tsx
index b9e5a8fc6..074b10e44 100644
--- a/apps/web/lib/features/manual-time/manage-member-component.tsx
+++ b/apps/web/lib/features/manual-time/manage-member-component.tsx
@@ -77,7 +77,8 @@ interface ManageOrMemberComponentProps<T extends Item> {
      */
     itemToValue: (item: T | null, valueKey: string) => string;
 
-    classNameTitle?: string
+    classNameTitle?: string;
+    defaultValue?: string
 }
 
 /**
@@ -94,7 +95,8 @@ export const ManageOrMemberComponent = <T extends Item>({
     handleChange,
     itemToString,
     itemToValue,
-    classNameTitle
+    classNameTitle,
+    defaultValue
 }: ManageOrMemberComponentProps<T>): JSX.Element => {
 
     /**
@@ -122,6 +124,7 @@ export const ManageOrMemberComponent = <T extends Item>({
                         {field.isRequired && <span className="text-[#de5505e1] ml-1 text-sm">*</span>}
                     </label>
                     <CustomCombobox
+                        defaultValue={defaultValue}
                         popoverWidth='w-full'
                         buttonWidth='w-full'
                         itemToString={(item) => itemToString(item, field.displayKey)}

From da84af198cb6c1beb3c104be9a64f60db5d91cf9 Mon Sep 17 00:00:00 2001
From: Innocent-akim <gentilakili98@gmail.com>
Date: Sat, 30 Nov 2024 10:31:19 +0200
Subject: [PATCH 2/6] Fix: deepscan

---
 .../timesheet/[memberId]/components/EditTaskModal.tsx         | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/apps/web/app/[locale]/timesheet/[memberId]/components/EditTaskModal.tsx b/apps/web/app/[locale]/timesheet/[memberId]/components/EditTaskModal.tsx
index 79661a52b..933fd1bb7 100644
--- a/apps/web/app/[locale]/timesheet/[memberId]/components/EditTaskModal.tsx
+++ b/apps/web/app/[locale]/timesheet/[memberId]/components/EditTaskModal.tsx
@@ -43,7 +43,7 @@ export function EditTaskModal({ isOpen, closeModal, dataTimesheet }: IEditTaskMo
 	};
 	const [timesheetData, setTimesheetData] = useState({
 		isBillable: dataTimesheet.isBillable,
-		projectId: dataTimesheet?.project?.id || '',
+		projectId: dataTimesheet.project?.id || '',
 		notes: dataTimesheet.description || '',
 	});
 
@@ -177,7 +177,7 @@ export function EditTaskModal({ isOpen, closeModal, dataTimesheet }: IEditTaskMo
 					</div>
 					<div className="w-full flex flex-col">
 						<ManageOrMemberComponent
-							defaultValue={dataTimesheet?.project?.name ?? ""}
+							defaultValue={dataTimesheet.project.name ?? ""}
 							classNameTitle={'text-[#282048] dark:text-gray-500  '}
 							fields={fields}
 							itemsLists={memberItemsLists}

From ccfc70b1d13834985581fe3536053c76df4e9dfc Mon Sep 17 00:00:00 2001
From: Innocent-akim <gentilakili98@gmail.com>
Date: Sat, 30 Nov 2024 10:33:32 +0200
Subject: [PATCH 3/6] Fix: deepscan

---
 .../[locale]/timesheet/[memberId]/components/AddTaskModal.tsx | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/apps/web/app/[locale]/timesheet/[memberId]/components/AddTaskModal.tsx b/apps/web/app/[locale]/timesheet/[memberId]/components/AddTaskModal.tsx
index 2f38dda15..f5cb32695 100644
--- a/apps/web/app/[locale]/timesheet/[memberId]/components/AddTaskModal.tsx
+++ b/apps/web/app/[locale]/timesheet/[memberId]/components/AddTaskModal.tsx
@@ -279,15 +279,12 @@ const OptimizedAccordion = ({ dateRange, handleFromChange, timeOptions, t }: {
         if (field === 'startTime' || field === 'endTime') {
             const { startTime, endTime } = updatedShifts[index];
 
-            // Validation des données
             if (!startTime || !endTime) return;
 
             if (convertToMinutes(startTime) >= convertToMinutes(endTime)) {
-                alert('L’heure de début doit être inférieure à l’heure de fin.');
                 return;
             }
             updatedShifts[index].totalHours = calculateTotalHoursHour(startTime, endTime);
-            // Détection des chevauchements
             const isOverlapping = shifts.some((shift, i) => {
                 if (i === index || !shift.startTime || !shift.endTime) return false;
 
@@ -303,7 +300,6 @@ const OptimizedAccordion = ({ dateRange, handleFromChange, timeOptions, t }: {
             });
 
             if (isOverlapping) {
-                alert('Le shift modifié chevauche un autre shift existant.');
                 return;
             }
         }

From 65ca615d22ab52fad9b84c69d8411d82279f512b Mon Sep 17 00:00:00 2001
From: Innocent-akim <gentilakili98@gmail.com>
Date: Sat, 30 Nov 2024 10:54:57 +0200
Subject: [PATCH 4/6] Fix: deepscan

---
 .../[memberId]/components/AddTaskModal.tsx    | 11 ++++---
 .../[memberId]/components/EditTaskModal.tsx   | 30 ++++++++++++++-----
 .../manual-time/manage-member-component.tsx   |  5 ++--
 3 files changed, 30 insertions(+), 16 deletions(-)

diff --git a/apps/web/app/[locale]/timesheet/[memberId]/components/AddTaskModal.tsx b/apps/web/app/[locale]/timesheet/[memberId]/components/AddTaskModal.tsx
index f5cb32695..5e13b733e 100644
--- a/apps/web/app/[locale]/timesheet/[memberId]/components/AddTaskModal.tsx
+++ b/apps/web/app/[locale]/timesheet/[memberId]/components/AddTaskModal.tsx
@@ -281,18 +281,17 @@ const OptimizedAccordion = ({ dateRange, handleFromChange, timeOptions, t }: {
 
             if (!startTime || !endTime) return;
 
-            if (convertToMinutes(startTime) >= convertToMinutes(endTime)) {
+            if (convertToMinutesHour(startTime) >= convertToMinutesHour(endTime)) {
                 return;
             }
             updatedShifts[index].totalHours = calculateTotalHoursHour(startTime, endTime);
             const isOverlapping = shifts.some((shift, i) => {
                 if (i === index || !shift.startTime || !shift.endTime) return false;
 
-                const currentStart = convertToMinutes(startTime);
-                const currentEnd = convertToMinutes(endTime);
-                const shiftStart = convertToMinutes(shift.startTime);
-                const shiftEnd = convertToMinutes(shift.endTime);
-
+                const currentStart = convertToMinutesHour(startTime);
+                const currentEnd = convertToMinutesHour(endTime);
+                const shiftStart = convertToMinutesHour(shift.startTime);
+                const shiftEnd = convertToMinutesHour(shift.endTime);
                 return (
                     (currentStart < shiftEnd && currentEnd > shiftStart) ||
                     (currentStart === shiftStart && currentEnd === shiftEnd)
diff --git a/apps/web/app/[locale]/timesheet/[memberId]/components/EditTaskModal.tsx b/apps/web/app/[locale]/timesheet/[memberId]/components/EditTaskModal.tsx
index 933fd1bb7..d4f069008 100644
--- a/apps/web/app/[locale]/timesheet/[memberId]/components/EditTaskModal.tsx
+++ b/apps/web/app/[locale]/timesheet/[memberId]/components/EditTaskModal.tsx
@@ -28,13 +28,16 @@ export function EditTaskModal({ isOpen, closeModal, dataTimesheet }: IEditTaskMo
 	});
 
 	const { h: hours, m: minutes } = secondsToTime(dataTimesheet.timesheet.duration);
+
 	const [timeRange, setTimeRange] = useState<{ startTime: string; endTime: string }>({
-		startTime: '',
-		endTime: '',
+		startTime: dataTimesheet.timesheet?.startedAt
+			? dataTimesheet.timesheet.startedAt.toString().slice(0, 5)
+			: '',
+		endTime: dataTimesheet.timesheet?.stoppedAt
+			? dataTimesheet.timesheet.stoppedAt.toString().slice(0, 5)
+			: '',
 	});
 
-
-
 	const updateTime = (key: 'startTime' | 'endTime', value: string) => {
 		setTimeRange(prevState => ({
 			...prevState,
@@ -65,6 +68,15 @@ export function EditTaskModal({ isOpen, closeModal, dataTimesheet }: IEditTaskMo
 
 	const handleUpdateSubmit = useCallback(async (e: FormEvent<HTMLFormElement>) => {
 		e.preventDefault();
+		if (!timeRange.startTime || !timeRange.endTime) {
+			alert('Please enter valid start and end times.');
+			return;
+		}
+		if (!/^\d{2}:\d{2}$/.test(timeRange.startTime) || !/^\d{2}:\d{2}$/.test(timeRange.endTime)) {
+			alert('Time format should be HH:MM.');
+			return;
+		}
+
 		const startedAt = new Date(dateRange.date ?? new Date());
 		const stoppedAt = new Date(dateRange.date ?? new Date());
 		const [startHours, startMinutes] = timeRange.startTime.split(':').map(Number);
@@ -93,7 +105,9 @@ export function EditTaskModal({ isOpen, closeModal, dataTimesheet }: IEditTaskMo
 			isRequired: true,
 			valueKey: 'id',
 			displayKey: 'name',
-			element: 'Project'
+			element: 'Project',
+			defaultValue: dataTimesheet.project.name
+
 		},
 	];
 
@@ -106,7 +120,7 @@ export function EditTaskModal({ isOpen, closeModal, dataTimesheet }: IEditTaskMo
 			isOpen={isOpen}
 			showCloseIcon
 			title={'Edit Task'}
-			className="bg-light--theme-light dark:bg-dark--theme-light p-5 rounded-xl w-full md:w-40 md:min-w-[30rem] justify-start h-[auto]"
+			className="bg-light--theme-light dark:bg-dark--theme-light p-5 rounded-xl w-full md:min-w-[32rem] justify-start h-[auto]"
 			titleClass="font-bold flex justify-start w-full">
 			<form onSubmit={handleUpdateSubmit} className="flex flex-col w-full">
 				<div className="flex flex-col border-b border-b-slate-100 dark:border-b-gray-700">
@@ -142,6 +156,9 @@ export function EditTaskModal({ isOpen, closeModal, dataTimesheet }: IEditTaskMo
 								aria-label="Start time"
 								aria-describedby="start-time-error"
 								type="time"
+								min="00:00"
+								max="23:59"
+								pattern="[0-9]{2}:[0-9]{2}"
 								value={timeRange.startTime}
 								onChange={(e) => updateTime("startTime", e.target.value)}
 								className="w-full p-1 border font-normal border-slate-300 dark:border-slate-600 dark:bg-dark--theme-light rounded-md"
@@ -177,7 +194,6 @@ export function EditTaskModal({ isOpen, closeModal, dataTimesheet }: IEditTaskMo
 					</div>
 					<div className="w-full flex flex-col">
 						<ManageOrMemberComponent
-							defaultValue={dataTimesheet.project.name ?? ""}
 							classNameTitle={'text-[#282048] dark:text-gray-500  '}
 							fields={fields}
 							itemsLists={memberItemsLists}
diff --git a/apps/web/lib/features/manual-time/manage-member-component.tsx b/apps/web/lib/features/manual-time/manage-member-component.tsx
index 074b10e44..c4fa127ca 100644
--- a/apps/web/lib/features/manual-time/manage-member-component.tsx
+++ b/apps/web/lib/features/manual-time/manage-member-component.tsx
@@ -32,6 +32,7 @@ interface ManageOrMemberComponentProps<T extends Item> {
         isRequired: boolean;
         valueKey: string; // Key for extracting the item's value
         displayKey: string; // Key for extracting the item's display text
+        defaultValue?: string
     }[];
 
     /**
@@ -78,7 +79,6 @@ interface ManageOrMemberComponentProps<T extends Item> {
     itemToValue: (item: T | null, valueKey: string) => string;
 
     classNameTitle?: string;
-    defaultValue?: string
 }
 
 /**
@@ -96,7 +96,6 @@ export const ManageOrMemberComponent = <T extends Item>({
     itemToString,
     itemToValue,
     classNameTitle,
-    defaultValue
 }: ManageOrMemberComponentProps<T>): JSX.Element => {
 
     /**
@@ -124,7 +123,7 @@ export const ManageOrMemberComponent = <T extends Item>({
                         {field.isRequired && <span className="text-[#de5505e1] ml-1 text-sm">*</span>}
                     </label>
                     <CustomCombobox
-                        defaultValue={defaultValue}
+                        defaultValue={field.defaultValue}
                         popoverWidth='w-full'
                         buttonWidth='w-full'
                         itemToString={(item) => itemToString(item, field.displayKey)}

From 72200274a1a72b645ad72543bd8342adc8229ff3 Mon Sep 17 00:00:00 2001
From: Innocent-akim <gentilakili98@gmail.com>
Date: Sat, 30 Nov 2024 10:57:05 +0200
Subject: [PATCH 5/6] fix: deep scan

---
 .../timesheet/[memberId]/components/AddTaskModal.tsx         | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/apps/web/app/[locale]/timesheet/[memberId]/components/AddTaskModal.tsx b/apps/web/app/[locale]/timesheet/[memberId]/components/AddTaskModal.tsx
index 5e13b733e..f9ba3321a 100644
--- a/apps/web/app/[locale]/timesheet/[memberId]/components/AddTaskModal.tsx
+++ b/apps/web/app/[locale]/timesheet/[memberId]/components/AddTaskModal.tsx
@@ -232,10 +232,7 @@ const OptimizedAccordion = ({ dateRange, handleFromChange, timeOptions, t }: {
     const [shifts, setShifts] = React.useState<Shift[]>([
         { startTime: '', endTime: '', totalHours: '00:00h', dateFrom: new Date() },
     ])
-    const convertToMinutes = (time: string): number => {
-        const [hours, minutes] = time.split(':').map(Number);
-        return hours * 60 + minutes;
-    };
+
     const convertToMinutesHour = (time: string): number => {
         const [hourMinute, period] = time.split(' ');
         const [hours, minutes] = hourMinute.split(':').map(Number);

From d1d5389886e929dc0059c1ea90e69d9946628d8f Mon Sep 17 00:00:00 2001
From: Innocent-akim <gentilakili98@gmail.com>
Date: Sat, 30 Nov 2024 11:01:27 +0200
Subject: [PATCH 6/6] fix: deep scan

---
 .../[memberId]/components/EditTaskModal.tsx   | 23 ++++++++++++++-----
 1 file changed, 17 insertions(+), 6 deletions(-)

diff --git a/apps/web/app/[locale]/timesheet/[memberId]/components/EditTaskModal.tsx b/apps/web/app/[locale]/timesheet/[memberId]/components/EditTaskModal.tsx
index d4f069008..3daa25980 100644
--- a/apps/web/app/[locale]/timesheet/[memberId]/components/EditTaskModal.tsx
+++ b/apps/web/app/[locale]/timesheet/[memberId]/components/EditTaskModal.tsx
@@ -77,12 +77,23 @@ export function EditTaskModal({ isOpen, closeModal, dataTimesheet }: IEditTaskMo
 			return;
 		}
 
-		const startedAt = new Date(dateRange.date ?? new Date());
-		const stoppedAt = new Date(dateRange.date ?? new Date());
-		const [startHours, startMinutes] = timeRange.startTime.split(':').map(Number);
-		startedAt.setHours(startHours, startMinutes);
-		const [endHours, endMinutes] = timeRange.endTime.split(':').map(Number);
-		stoppedAt.setHours(endHours, endMinutes);
+		const baseDate = dateRange.date ?? new Date();
+		const startedAt = new Date(
+			Date.UTC(
+				baseDate.getFullYear(),
+				baseDate.getMonth(),
+				baseDate.getDate(),
+				...timeRange.startTime.split(':').map(Number)
+			)
+		);
+		const stoppedAt = new Date(
+			Date.UTC(
+				baseDate.getFullYear(),
+				baseDate.getMonth(),
+				baseDate.getDate(),
+				...timeRange.endTime.split(':').map(Number)
+			)
+		);
 		await updateTimesheet({
 			id: dataTimesheet.timesheetId,
 			isBillable: timesheetData.isBillable,