Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snapshot upgrader need metadata #919

Open
nlips opened this issue Jan 18, 2022 · 4 comments
Open

Snapshot upgrader need metadata #919

nlips opened this issue Jan 18, 2022 · 4 comments

Comments

@nlips
Copy link

nlips commented Jan 18, 2022

My SnapshotUpgrader need to retrieve data from the aggregate's events.
For this, it use the IEventStore instance.
But it should only take into account events whose sequence is less than or equal to that of the snapshot.
This information should be an argument of the UpgradeAsync method.
Moreover IEventStore should provide a method to get a range of events.

@nlips
Copy link
Author

nlips commented Jan 18, 2022

Actually I can't use IEventStore... I don't have the aggregate's id !

@rasmus rasmus added this to the 1.0 milestone Feb 10, 2022
@github-actions
Copy link

github-actions bot commented Apr 8, 2023

Hello there!

We hope you are doing well. We noticed that this issue has not seen any activity in the past 90 days.
We consider this issue to be stale and will be closing it within the next seven days.

If you still require assistance with this issue, please feel free to reopen it or create a new issue.

Thank you for your understanding and cooperation.

Best regards,
EventFlow

@github-actions github-actions bot added the stale label Apr 8, 2023
@rasmus rasmus added stale-exempt and removed stale labels Apr 8, 2023
@github-actions
Copy link

github-actions bot commented Jul 8, 2023

Hello there!

We hope you are doing well. We noticed that this issue has not seen any activity in the past 90 days.
We consider this issue to be stale and will be closing it within the next seven days.

If you still require assistance with this issue, please feel free to reopen it or create a new issue.

Thank you for your understanding and cooperation.

Best regards,
EventFlow

@github-actions github-actions bot added the stale label Jul 8, 2023
@SeWaS
Copy link
Contributor

SeWaS commented Oct 30, 2023

Hello there 👋

Long-time lurker here. Decided that it's time to contribute a bit to the repository.

The underlying idea of enabling the event store to load domain events within a given sequence-number range makes sense to me. I would go ahead and prepare a PR if still relevant.

Regarding your snapshot upgrading question, would it help if the specific snapshots in your application would carry their respective aggregate Id in the payload? That way you would have access to it when upgrading from one snapshot version to the other, no?
In case you found a solution to the problem, I would be curious what it was :)

Cheers

rasmus added a commit that referenced this issue Mar 12, 2024
Issue #919: Enable IEventStore to load events up to a given sequence number
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants