Fixed browser-only usage of Emmett package introduced in 0.20.0 #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oskardudycz
force-pushed
the
browser_compatibility_commander
branch
3 times, most recently
from
fb54aa4
to
960835c
Compare
oskardudycz
force-pushed
the
browser_compatibility_commander
branch
from
960835c
to
6ff3ab6
Compare
…ect regression/fix
oskardudycz
force-pushed
the
browser_compatibility_commander
branch
from
e89c473
to
d8f66ab
Compare
oskardudycz
changed the title
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made plugin code unrelated to
commanderpackage. Thanks to that even if Emmett hascommanderpeer dependency, it'll be only loaded for Command Line usage (when@event-driven-io/emmett/cliis imported.Added test to detect future regression. See:
Fixes #124
Fixes #74