This repository has been archived by the owner on Jul 16, 2024. It is now read-only.
Implementing Views #80
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benbrimeyer
reviewed
Jan 9, 2024
| end | ||
|
|
||
| local dyingPeople = world:query(Player, Health, Poison):view() | ||
| local remainingHealth = dyingPeople:get(entity) |
There was a problem hiding this comment.
Its unclear what "entity" is meant to be in this example to me. Is this an entityId?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just one way to resolve #79 where we could potentially extend the API instead of changing
queryResult:snapshot(). Currently the order of entities is undefined and may differ from a query or snapshot. Maybe we can fix this by using linked lists or something, need thoughts on this.TODO
- [ ] Should be able to view following aDecided that shouldn't block this featurequeryResult:without()