Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow canceling download of large files #46

Open
dlech opened this issue Oct 18, 2017 · 1 comment
Open

Allow canceling download of large files #46

dlech opened this issue Oct 18, 2017 · 1 comment

Comments

@dlech
Copy link
Member

dlech commented Oct 18, 2017

Spin off of #37.

We can currently cancel downloading many files by finishing the download of the current file and skipping the rest. However, it would be nice to be able to cancel the download of a large file in the middle of the download as well.

This will require changing the implementation of the Device.put function to be cancelable instead of relying on the ssh2 module fastPut. It will probably also require that we save the remote file with a different name and then rename/replace the file with the correct name so that we don't end up with half of a file on the remote device.

@dlech
Copy link
Member Author

dlech commented Nov 7, 2017

This should also be done for uploading files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant