Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix failing links #278

Merged
merged 2 commits into from
Oct 13, 2016
Merged

fix failing links #278

merged 2 commits into from
Oct 13, 2016

Conversation

dlech
Copy link
Member

@dlech dlech commented Oct 12, 2016

This fixes the kernel.org links. OpenRoberta is still failing, but they just upgraded their server, so it may or may not resolve itself.

I'm wondering if we should just stop checking links with travis altogherter since it can't seem to handle https very well.

Hopefully this is temporary and we can revert this since there
are many links.
@WasabiFan
Copy link
Member

I'm wondering if we should just stop checking links with travis altogherter since it can't seem to handle https very well.

The CI server has caught so many broken links that I would feel pretty insecure without it. When I originally enabled link checking, I had to fix 50-100 real broken links; the hacker docks, for example, had major issues. LEGO has also been repeatedly breaking links and rarely adding proper redirects. Despite the fact that it can be a pain to special-case the HTTPS endpoints, I still think it provides significant benefit.

It would probably be a good step to reach out to Travis support and/or open an issue on the proofer library to see if there's a real solution to this.

There are, however, workarounds we can use to make this significantly better. I currently have it configured to run nightly builds of master and have been watching those as they happen to make sure that things are running smoothly. I also wrote a Ruby script that I was trying out a few months back which would only fail the build for errors in modified files, but I didn't get a chance to test it out thoroughly enough to be confident in it.

@dlech dlech merged commit 6583b5b into ev3dev:master Oct 13, 2016
@dlech
Copy link
Member Author

dlech commented Oct 13, 2016

Reopening #155 for now...

@dlech dlech deleted the kernel.org branch October 13, 2016 00:57
markusmo3 added a commit to iluwatar/java-design-patterns that referenced this pull request Nov 21, 2016
travis seems to have a problem with some webpages, i still dont know the real cause but this fixed it on my fork.

sauce:
ev3dev/ev3dev.github.io#278
https://github.com/dlech/ev3dev.github.io/blob/bb7f97b3505adc1a52c21a14c4f74820ab4d36c0/cibuild.sh

fixes #522
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants