Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include TypeScript typings #38

Open
ORESoftware opened this issue Oct 28, 2017 · 5 comments
Open

Include TypeScript typings #38

ORESoftware opened this issue Oct 28, 2017 · 5 comments

Comments

@ORESoftware
Copy link

It would be nice if this lib could export TypeScript typings

if you're interested I could add them

@stevemao
Copy link
Collaborator

I'd say PR welcome :)

@nicolaspernoud
Copy link

nicolaspernoud commented Feb 20, 2018

Type definitions for replacestream 4.0.3

declare module 'replacestream' {
  interface ReplaceStreamOptions {
    limit?: number;
    encoding?: string;
    maxMatchLen?: number;
  }
  export = ReplaceStream;
  function ReplaceStream(
    search: RegExp | string,
    replace: (() => string) | string,
    options?: ReplaceStreamOptions
  ): any;
}

@ORESoftware
Copy link
Author

ORESoftware commented Feb 20, 2018

I thought 'namespace' is supposed to be used in place of 'module'? idk

@twawszczak
Copy link

@ORESoftware maybe is possible add it to that repo or to @types ?

@stevemao
Copy link
Collaborator

Please just go ahead and make a PR here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants