Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish the CertLogic runnner as an artifact to Maven Central. #12

Open
SZoerner opened this issue Jun 28, 2021 · 8 comments
Open

Publish the CertLogic runnner as an artifact to Maven Central. #12

SZoerner opened this issue Jun 28, 2021 · 8 comments
Assignees
Labels
enhancement New feature or request

Comments

@SZoerner
Copy link

Current Implementation

Verifiers that would like to integrate the CertLogic RuleEngine as a library currently need to reference the source code directly, or compile it locally and reference their own build.

Suggested Enhancement

By publishing the compiled artefact to a public repository (e.g. as a Github Action pushing the jar to Maven Central), consumers can include the latest version without manual effort.

Expected Benefits

By using a public maven repo, it's easy for downstream dependencies to keep up to date with new feature and bugfixes without manual intervention.

@SZoerner SZoerner added the enhancement New feature or request label Jun 28, 2021
@daniel-eder
Copy link
Member

I believe Maven Central is unlikely at this point as the entire project uses Github Packages, but for Github Packages I can see the benefit, I'll forward it

@wkornewald
Copy link

Do you have an estimate when the package might be available?

@daniel-eder
Copy link
Member

I don't have an ETA yet - but we'll keep this issue updated once our dev's can get to it.
If anyone familiar with the build process would like to provide a PR for a GitHub Action (e.g. based on https://github.com/eu-digital-green-certificates/dgc-lib/tree/main/.github/workflows ) we'd be happy to review it.

@vaubaehn
Copy link

vaubaehn commented Jul 1, 2021

If anyone familiar with the build process would like to provide a PR for a GitHub Action (e.g. based on https://github.com/eu-digital-green-certificates/dgc-lib/tree/main/.github/workflows ) we'd be happy to review it.

pinging @mlenkeit , as I believe that could also help you - do you know some CWA devs who could do some magic here?

@mlenkeit
Copy link
Collaborator

mlenkeit commented Jul 2, 2021

@vaubaehn we are currently focusing on our fork, as the module contains network and persistence layers that conflict with settings in CWA. We are trying to keep the diff as little as necessary so facilitate updates from upstream.

@wkornewald
Copy link

wkornewald commented Jul 2, 2021

You mean that the network and persistence layers will be decoupled, so that certlogic can focus just on its primary task? Where is the fork?

@vaubaehn
Copy link

vaubaehn commented Jul 2, 2021

@mlenkeit

@vaubaehn we are currently focusing on our fork, as the module contains network and persistence layers that conflict with settings in CWA. We are trying to keep the diff as little as necessary so facilitate updates from upstream.

At the time of pinging you, I was assuming that "only" taking care of #17 could result in 1:1 upstream. After your last comment I found the fork, and it looks like a good idea 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

6 participants