Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HJ-128 - Adding CustomReport.config.column_order field #5543

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

HJ-128 - Adding CustomReport.config.column_order field #5543

wants to merge 2 commits into from

Conversation

andres-torres-marroquin
Copy link
Contributor

Closes #HJ-128

Description Of Changes

Adding CustomReport.config.column_order field

Code Changes

  • Adding CustomReport.config.column_order field

Steps to Confirm

  1. list any manual steps for reviewers to confirm the changes

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
  • Followup issues:
    • Followup issues created (include link)
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@vercel Vercel
Copy link

vercel bot commented Nov 26, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fides-plus-nightly ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 29, 2024 1:07am

@cypress Cypress
Copy link

cypress bot commented Nov 26, 2024 •
edited
Loading

fides    Run #11204

Run Properties:  status check passed Passed #11204  •  git commit d459b0a1e7 ℹ️: Merge dc9b2f18d15fae6c0376ca81db26ebd48f2a3328 into e90b858070601e9ea2ad06f9a15c...
Project fides
Branch Review refs/pull/5543/merge
Run status status check passed Passed #11204
Run duration 00m 38s
Commit git commit d459b0a1e7 ℹ️: Merge dc9b2f18d15fae6c0376ca81db26ebd48f2a3328 into e90b858070601e9ea2ad06f9a15c...
Committer Andres Torres
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@andres-torres-marroquin