Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LA-162: Adds new lib to set global pytest timeout #5536

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

LA-162: Adds new lib to set global pytest timeout #5536

wants to merge 2 commits into from

Conversation

eastandwestwind
Copy link
Contributor

Closes https://ethyca.atlassian.net/browse/LA-162

Description Of Changes

Allows pipeline to fail if tests timeout. Previously, tests that timed-out counted as a "pass" in CI.

Code Changes

  • Adds new lib to control pytest timeout
  • Sets default timeout globally to 300 seconds

Steps to Confirm

  1. Confirm CI now fails for specific test

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
  • Followup issues:
    • Followup issues created (include link)
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@vercel Vercel
Copy link

vercel bot commented Nov 25, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview Nov 26, 2024 4:38pm

@cypress Cypress
Copy link

cypress bot commented Nov 25, 2024 •
edited
Loading

fides    Run #11190

Run Properties:  status check passed Passed #11190  •  git commit c2b32af361 ℹ️: Merge daab2808dca70c3cc4a99035ef8dcbda602c27ed into a54b430ec5570613d21bf058e5f8...
Project fides
Branch Review refs/pull/5536/merge
Run status status check passed Passed #11190
Run duration 00m 39s
Commit git commit c2b32af361 ℹ️: Merge daab2808dca70c3cc4a99035ef8dcbda602c27ed into a54b430ec5570613d21bf058e5f8...
Committer Catherine Smith
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@eastandwestwind