Block.getTransaction always throws "no such tx" error

[dumbeng]

Ethers Version

6.13.4

Search Terms

provider

Describe the Problem

When using block.getTransaction("{0xTxHash}"), this will always fail due to a comparison issue in the Block class at src/providers/provider.ts.

 async getTransaction(indexOrHash: number | string): Promise<TransactionResponse> {
        // Find the internal value by its index or hash
        let tx: string | TransactionResponse | undefined = undefined;
        if (typeof(indexOrHash) === "number") {
            tx = this.#transactions[indexOrHash];

        } else {
            const hash = indexOrHash.toLowerCase();
            for (const v of this.#transactions) {
                if (typeof(v) === "string") {
                    if (v !== hash) { continue; }
                    tx = v;
                    break;
                } else {
                    if (v.hash === hash) { continue; } // <== This should be v.hash !== hash
                    tx = v;
                    break;
                }
            }
        }
        if (tx == null) { throw new Error("no such tx"); }
        // ...
}

But it's kind of weird that I cannot reproduce this in the playground, but this error happens every time when I run the code locally. Btw I can create a PR for this if needed.

Code Snippet

The following code should reproduce the issue:

await (await provider.getBlock(2000000, true)).getTransaction('0xc55e2b90168af6972193c1f86fa4d7d7b31a29c156665d15b9cd48618b5177ef')

Contract ABI

No response

Errors

The error is `no such tx`

Environment

node.js (v12 or newer)

Environment (Other)

No response

[jasonandjay]

This is indeed a bug, we will fix it immediately.

Thank you for your feedback🫡