Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add socket-level config #38

Open
jacobkaufmann opened this issue Mar 18, 2023 · 2 comments
Open

add socket-level config #38

jacobkaufmann opened this issue Mar 18, 2023 · 2 comments

Comments

@jacobkaufmann
Copy link
Collaborator

add socket-level configuration to constructor(s)

the config could include the following:

  • max UDP packet size
  • max connections
@carver
Copy link
Contributor

carver commented Jun 26, 2023

I don't think we're ever practically changing connection configurations from one connection to another. I'm starting to think maybe everything could be moved to a Socket level config. That seems easier for the caller than managing two separate configs. What do you think?

@carver
Copy link
Contributor

carver commented Jun 26, 2023

Splitting the Config into two parts seems to push us in the unpleasant direction of #92.

I'm continuing to lean toward fully removing ConnectionConfig and replacing it with a SocketConfig (or StreamConfig?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants