Foundry ci setup #14140
Foundry ci setup #14140
Conversation
r0qs
added
the
has dependencies
r0qs
force-pushed
the
external-tests-refactor
branch
2 times, most recently
from
9024e52 to
957a727
Compare
r0qs
force-pushed
the
external-tests-refactor
branch
2 times, most recently
from
b754128 to
28a9592
Compare
r0qs
force-pushed
the
external-tests-refactor
branch
from
5758c1f to
75960e6
Compare
| @@ -705,14 +774,8 @@ jobs: | |||
| <<: *base_cimg_small | |||
There was a problem hiding this comment.
Would be best if we could avoid having to install Python and pip every time and just have it as a part of the image. Maybe we should switch chk_pylint, chk_proofs and c_ext_benchmarks to base_python_small instead?
Though I guess we still won't avoid it completely - for Foundry we want rust image as a base. We could also leave it like this in this PR and refactor separately.
There was a problem hiding this comment.
Yes, we could do the switch but probably in another PR as you suggested.
.circleci/config.yml
Outdated
| echo $FOUNDRY_RELEASE_SHA > /tmp/workspace/foundry-release-sha | ||
| - restore_cache: | ||
| keys: | ||
| - foundry-<< parameters.version >>-{{ checksum "/tmp/workspace/foundry-release-sha" }} |
There was a problem hiding this comment.
You have the hash in an env var, you should be able to avoid storing it in a file and just use it directly according to save_cache docs:
| - foundry-<< parameters.version >>-{{ checksum "/tmp/workspace/foundry-release-sha" }} | |
| - foundry-<< parameters.version >>-{{ .Environment.FOUNDRY_RELEASE_SHA }} |
There was a problem hiding this comment.
Hum...I couldn't make it work in the way you suggested. If I understand correctly their docs, this syntax does not include environment variables that defined in our CI scripts, only the ones that are added in the context of the project/organization CircleCI settings or that are already exported by CircleCI.
r0qs
force-pushed
the
foundry-ci-setup
branch
2 times, most recently
from
aa25c22 to
57fd316
Compare
r0qs
force-pushed
the
foundry-ci-setup
branch
2 times, most recently
from
a39db6a to
e573e83
Compare
r0qs
removed
the
has dependencies
This PR extract the Foundry/python CI part from #13873 to simplify the review.
Depends on #14064