Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

discv5_updateNodeInfo endpoint: socker parameter format #355

Closed
meldsun0 opened this issue Nov 26, 2024 · 1 comment
Closed

discv5_updateNodeInfo endpoint: socker parameter format #355

meldsun0 opened this issue Nov 26, 2024 · 1 comment

Comments

@meldsun0
Copy link

When implementing discv5_updateNodeInfo I noticed that the format suggested, is for ip4. Is this correct or the socket parameter should be a multiaddress ? If that is the case the attribute isTcp may not be necessary.

@kdeme
Copy link
Collaborator

kdeme commented Nov 26, 2024

This PR is related (but a bit more broad) to this issue: #207

Not much priority on this however as the method is nowhere used (so we could also just remove it).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants