Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more tests for EIP-7610 (create address collistion) #1037

Open
chfast opened this issue Sep 28, 2024 · 0 comments
Open

Add more tests for EIP-7610 (create address collistion) #1037

chfast opened this issue Sep 28, 2024 · 0 comments
Labels
tests Testing infrastructure

Comments

@chfast
Copy link
Member

chfast commented Sep 28, 2024

EIP-7610.

A comment from the code:

bool is_create_collision(const Account& acc) noexcept
{
    // - what if an account had storage but is destructed?
    // - what if an account had cold storage but it was emptied?
    // - what if an account without cold storage gain one?
    if (acc.nonce != 0)
        return true;
    if (acc.code_hash != Account::EMPTY_CODE_HASH)
        return true;
    if (acc.has_cold_storage)
        return true;

    // The hot storage is ignored because it can contain elements from access list.
    // TODO: Is this correct for destructed accounts?
    assert(!acc.destructed && "untested");
    return false;
}
@chfast chfast added the tests Testing infrastructure label Sep 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Testing infrastructure
Projects
None yet
Development

No branches or pull requests

1 participant