Session handling #65
Open
Session handling #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Remove the concept of an end state and an “abstract renderable state”. Before, all renderable states were either “abstract” or realized as “end (renderable) states” or “async (renderable) states”. This was just too complicated. Now, we can think exclusively in terms of branching only states (hidden states), renderable only states (end states and states that’ll be async hijacked), and normal states. Closes #2. 2. Give a static definition of a valid state. I’m not sure how well this’ll work (b/c idk if typescript can tell enough of the time that a property is undefined on a state statically), but it’s worth a shot.
Codecov Report
@@ Coverage Diff @@
## master #65 +/- ##
==========================================
- Coverage 95.43% 95.31% -0.12%
==========================================
Files 9 9
Lines 197 192 -5
Branches 52 50 -2
==========================================
- Hits 188 183 -5
Misses 9 9
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finally add session handling, now that we know Twilio works with cookies well enough for us to use express-session.