Infinity Polling Should Handle Exceptions

[All-The-Foxes]

It is wild to me that any error, including 429 and 401, is ignored during polling. Polling needs to break for 401 errors (unauthorized) and listen to 429 errors (too many requests). There shouldn't be any "unhandled exceptions" in the logs, let alone like 20 of them at once any time there is a bad gateway. Every exception, no matter what it is, should always be handled.

[coder2020official]

You mean for async?

[All-The-Foxes]

Yes.

[coder2020official]

By "not handled" in async, we refer to the fact that your exception handler did not handle this exception. This will not crush the code if you have non_stop set to True.

[All-The-Foxes]

An I supposed to use my own handler for the async version?

[coder2020official]

If you wish so.
Honestly, it is just a wording difference. While sync says "exception occured" or smth, async says it isn't handled as an addition I think

[All-The-Foxes]

Yes, async says unhandled exception, but the exceptions are also not handled. 429 errors are ignored, polling retries despite getting 401 errors, etc. They should be handled.

[coder2020official]

What do you mean by 'exceptions are also not handled'

[All-The-Foxes]

I don't know how else to say it. Exceptions are logged as tracebacks and not handled.

[All-The-Foxes]

To add to this, a full traceback for things like request timeouts just makes a mess in the logs. We don't need a traceback for Telegram server issues like bad gateways and such.