Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stops: add checks point_near_origin and point_near_pole #202

Open
2 tasks
AntoineAugusti opened this issue Sep 4, 2024 · 5 comments
Open
2 tasks

stops: add checks point_near_origin and point_near_pole #202

AntoineAugusti opened this issue Sep 4, 2024 · 5 comments

Comments

@AntoineAugusti
Copy link
Member

AntoineAugusti commented Sep 4, 2024

Consider adding 2 new rules validating latitude/longitude for stops. These 2 checks are part of the canonical GTFS Validator.

Rules

ℹ️ 🙏 The rules are coming from Google's and MobilityData validators.

@thbar
Copy link
Contributor

thbar commented Sep 4, 2024

Implemented in #201, we're going to do a bit of live testing I think!

@thbar thbar closed this as completed Sep 4, 2024
@AntoineAugusti AntoineAugusti reopened this Sep 4, 2024
@AntoineAugusti
Copy link
Member Author

@thbar #201 only outputs an error for (0, 0), this issue is about adding other checks

@thbar
Copy link
Contributor

thbar commented Sep 4, 2024

Sorry, I was a bit too fast !

Updating the doc for clarity.

@thbar
Copy link
Contributor

thbar commented Sep 4, 2024

I have updated the issue text (created separated tasks) to make it clearer for reviewers (since the issue title mentioned 2 checks, but the body did not).

Also @AntoineAugusti, I recommend an explicit attribution of the original implementation at the very top of the issues and PR, something like: "this is a backport of rules xyz from the MobilityData validator".

While not strictly required from a license point of view if I understand correctly, and while we already link there, a more explicit credit would be fair game in my opinion!

@AntoineAugusti
Copy link
Member Author

AntoineAugusti commented Sep 4, 2024

Updated the description to reflect that point_near_origin has not been implemented.

We have been disallowing (latitude=0, longitude=0) for several years but we should consider updating the rule to follow what Google and then MobilityData are doing with the point_near_origin rule.

I recommend an explicit attribution of the original implementation

Sure, done ✅ 🎩

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants