-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stops: add checks point_near_origin and point_near_pole #202
Comments
Implemented in #201, we're going to do a bit of live testing I think! |
Sorry, I was a bit too fast ! Updating the doc for clarity. |
I have updated the issue text (created separated tasks) to make it clearer for reviewers (since the issue title mentioned 2 checks, but the body did not). Also @AntoineAugusti, I recommend an explicit attribution of the original implementation at the very top of the issues and PR, something like: "this is a backport of rules xyz from the MobilityData validator". While not strictly required from a license point of view if I understand correctly, and while we already link there, a more explicit credit would be fair game in my opinion! |
Updated the description to reflect that We have been disallowing (latitude=0, longitude=0) for several years but we should consider updating the rule to follow what Google and then MobilityData are doing with the
Sure, done ✅ 🎩 |
Consider adding 2 new rules validating latitude/longitude for stops. These 2 checks are part of the canonical GTFS Validator.
Rules
point_near_origin
point_near_pole
ℹ️ 🙏 The rules are coming from Google's and MobilityData validators.
The text was updated successfully, but these errors were encountered: