From 4a6a8a14a711a6ea2eb5e0187cfd507de484f73c Mon Sep 17 00:00:00 2001
From: Jonas <43351280+hurvan@users.noreply.github.com>
Date: Tue, 28 May 2024 12:37:14 +0200
Subject: [PATCH] Periodic value was always default (#100)

* The periodic was not actually sent as it should, only the default value was serialized. fixing test to cover this

* bump version for bug fix
---
 streaming_data_types/_version.py              |  2 +-
 .../forwarder_config_update_fc00.py           | 32 +++++++++++--------
 tests/test_fc00.py                            |  1 +
 3 files changed, 21 insertions(+), 14 deletions(-)

diff --git a/streaming_data_types/_version.py b/streaming_data_types/_version.py
index 0416758..c012f41 100644
--- a/streaming_data_types/_version.py
+++ b/streaming_data_types/_version.py
@@ -1,4 +1,4 @@
 # Version is not directly defined in __init__ because that causes all
 # run time dependencies to become build-time dependencies when it is
 # imported in setup.py
-version = "0.26.0"
+version = "0.26.1"
diff --git a/streaming_data_types/forwarder_config_update_fc00.py b/streaming_data_types/forwarder_config_update_fc00.py
index 8d1ff84..2c2d355 100644
--- a/streaming_data_types/forwarder_config_update_fc00.py
+++ b/streaming_data_types/forwarder_config_update_fc00.py
@@ -40,19 +40,23 @@ def deserialise_fc00(buffer: Union[bytearray, bytes]) -> ConfigurationUpdate:
             stream_message = config_message.Streams(i)
             streams.append(
                 StreamInfo(
-                    stream_message.Channel().decode("utf-8")
-                    if stream_message.Channel()
-                    else "",
-                    stream_message.Schema().decode("utf-8")
-                    if stream_message.Schema()
-                    else "",
-                    stream_message.Topic().decode("utf-8")
-                    if stream_message.Topic()
-                    else "",
+                    (
+                        stream_message.Channel().decode("utf-8")
+                        if stream_message.Channel()
+                        else ""
+                    ),
+                    (
+                        stream_message.Schema().decode("utf-8")
+                        if stream_message.Schema()
+                        else ""
+                    ),
+                    (
+                        stream_message.Topic().decode("utf-8")
+                        if stream_message.Topic()
+                        else ""
+                    ),
                     stream_message.Protocol(),
-                    int(stream_message.Periodic().decode("utf-8"))
-                    if stream_message.Periodic()
-                    else 0,
+                    stream_message.Periodic() if stream_message.Periodic() else 0,
                 )
             )
     except flatbuffer_struct.error:
@@ -67,12 +71,14 @@ def serialise_stream(
     channel_offset: int,
     schema_offset: int,
     topic_offset: int,
+    periodic_offset: int,
 ) -> int:
     Stream.StreamStart(builder)
     Stream.StreamAddProtocol(builder, protocol)
     Stream.StreamAddTopic(builder, topic_offset)
     Stream.StreamAddSchema(builder, schema_offset)
     Stream.StreamAddChannel(builder, channel_offset)
+    Stream.StreamAddPeriodic(builder, periodic_offset)
     return Stream.StreamEnd(builder)
 
 
@@ -99,7 +105,7 @@ def serialise_fc00(config_change: UpdateType, streams: List[StreamInfo]) -> byte
             for stream in streams
         ]
         stream_offsets = [
-            serialise_stream(builder, stream.protocol, *stream_fields)
+            serialise_stream(builder, stream.protocol, *stream_fields, stream.periodic)
             for stream, stream_fields in zip(streams, stream_field_offsets)
         ]
 
diff --git a/tests/test_fc00.py b/tests/test_fc00.py
index 4ce5abc..49127ce 100644
--- a/tests/test_fc00.py
+++ b/tests/test_fc00.py
@@ -32,6 +32,7 @@ def test_serialises_and_deserialises_fc00_message_with_streams_correctly(self):
         assert entry.config_change == original_entry["config_change"]
         assert stream_1 in entry.streams
         assert stream_2 in entry.streams
+        assert stream_3 in entry.streams
 
     def test_serialises_and_deserialises_fc00_message_without_streams_correctly(self):
         """