-
Notifications
You must be signed in to change notification settings - Fork 7.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(esp-modbus): Update slave.c to fix the mode in esp-modbus example (IDFGH-14059) #14878
base: master
Are you sure you want to change the base?
Conversation
There is an issue in the lines that I have changed. I think it was copied over from the enum by mistake.
👋 Hello kabirwbt, we appreciate your contribution to this project! 📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more. 🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project. Click to see more instructions ...
Review and merge process you can expect ...
|
@alisitsyn can you please see if this is valid or is my understanding wrong. |
sha=8d2a1720640449d7e9b0fec6c1e49cd60ca301ef |
There is an issue in the lines that I have changed. I think it was copied over from the enum by mistake.
Description
Semi-colon was omitted in the old code and comma as written. I have changed both the offending lines to semi-colon endings.
Related
Testing
Checklist
Before submitting a Pull Request, please ensure the following: