-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New package releases #8
base: main
Are you sure you want to change the base?
Conversation
@tschundler would you mind reviewing the additions to the |
Ahh I missed #6, let's get that in first :) |
LGTM I patched one of my projects to use this branch and everything works fine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
LGTM - just tried it out and and used it to double check a timing-related PR I'm about to send, thanks. |
what is left to complete this PR please? I'd like to use it with esp-hal 21.1 |
Just wanted to get #6 merged, have not had a chance to look at it yet unfortunately due to other obligations. If somebody from the community can review/test that it would speed things up. Sorry for the delays, will do my best to get releases out this week. |
I did have a look at #6 and it looks good. I think an added example as mentioned in the comments would be a good idea. My question just echoes the comment above:
#6 seems to be adding a new functionality. Is that something that's needed for this PR? |
@AnthonyGrondin Can this be merged? Both latest release and the main branch can't be used with the latest esp-hal |
esp-hal
and other dev dependenciesesp-hal
README.md
files demonstrating how to build and run the examples.cargo/config.toml
files consistent between packagesLooks like we forgot to publish the initial version of
esp-hal-buzzer
when it was added, oops. Once this PR is merged I will publish both packages.Closes #7