Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package releases #8

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Conversation

jessebraham
Copy link
Member

  • Update both packages to use latest versions of esp-hal and other dev dependencies
  • Update MSRVs to match that of esp-hal
  • Add instructions to the README.md files demonstrating how to build and run the examples
  • Make .cargo/config.toml files consistent between packages

Looks like we forgot to publish the initial version of esp-hal-buzzer when it was added, oops. Once this PR is merged I will publish both packages.

Closes #7

@jessebraham
Copy link
Member Author

@tschundler would you mind reviewing the additions to the README.md files please? Have I included adequate information to get you up and running? Happy to make any additional changes if not!

@jessebraham
Copy link
Member Author

Ahh I missed #6, let's get that in first :)

@jessebraham jessebraham marked this pull request as draft October 14, 2024 08:03
@AnthonyGrondin
Copy link
Collaborator

LGTM

I patched one of my projects to use this branch and everything works fine.

Copy link

@bjoernQ bjoernQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tschundler
Copy link
Contributor

@tschundler would you mind reviewing the additions to the README.md files please? Have I included adequate information to get you up and running? Happy to make any additional changes if not!

LGTM - just tried it out and and used it to double check a timing-related PR I'm about to send, thanks.

@jamessizeland
Copy link

what is left to complete this PR please? I'd like to use it with esp-hal 21.1

@jessebraham
Copy link
Member Author

what is left to complete this PR please? I'd like to use it with esp-hal 21.1

Just wanted to get #6 merged, have not had a chance to look at it yet unfortunately due to other obligations. If somebody from the community can review/test that it would speed things up.

Sorry for the delays, will do my best to get releases out this week.

@horho77
Copy link

horho77 commented Oct 23, 2024

what is left to complete this PR please? I'd like to use it with esp-hal 21.1

Just wanted to get #6 merged, have not had a chance to look at it yet unfortunately due to other obligations. If somebody from the community can review/test that it would speed things up.

Sorry for the delays, will do my best to get releases out this week.

I did have a look at #6 and it looks good. I think an added example as mentioned in the comments would be a good idea.
Sorry to barge in... I have an internal fork of the hal-esp-smartled (from an older version of esp-hal) with added support for RGBW LEDs. I was hoping to submit a PR here at some point.

My question just echoes the comment above:

what is left to complete this PR please? I'd like to use it with esp-hal 21.1

#6 seems to be adding a new functionality. Is that something that's needed for this PR?

@okhsunrog
Copy link

@AnthonyGrondin Can this be merged? Both latest release and the main branch can't be used with the latest esp-hal

@AnthonyGrondin
Copy link
Collaborator

As far as I'm aware, this PR is waiting for #6 to get merged first.

I'd like to get #11 merged before cutting a new release of esp-hal-buzzer. Well, before publishing, since it has never been published.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document how to run examples
7 participants