Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timeseries with names containing dots are not compatible with fieldSpecs #141

Open
laaglu opened this issue Aug 28, 2019 · 0 comments
Open

Comments

@laaglu
Copy link

laaglu commented Aug 28, 2019

Hi,
I would like to use react-timeseries-charts/pond on my project (a monitoring infrastructure for a cloud provider) but I stumble on a kind of "dumb" problem related to field specs.

The metrics in this system are all organized using a naming scheme which uses dots. In this case, the dots do not have any relationship to a hierarchy of maps, they are just a way to name the metrics in a logical way. For instance, we have:

  • os.disk.inodes.count
  • os.disk.space.free
  • os.disk.space.min
  • os.multiprocess.runs.zookeeper.status
  • os.process.runs.nimbus.status
  • os.process.runs.redis.status
  • os.process.runs.storm.status

...

As you can see, this naming scheme prevents me from using pond, because pond interprets all the dots in metric names as field separators.

My question is: would you be willing to accept a patch to pond in which the user could specify the field separator used for field specs in the get() method of an event. '.' would remain the defaut (thus having no impact on existing code), but one could specify something else ('/' for instance in my case). I would then propose changes to react-timeseries-chart to add extra 'fieldSeparator' property to the various charts (again, with '.' default so that there is no impact on existing code) so one could specify the field separator for a given chart.

Regards

Lukas

laaglu pushed a commit to laaglu/pond that referenced this issue Aug 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant