Failed to import - octokit (types)

[ThisGuyCodes]

Failing module

• GitHub: https://github.com/octokit/octokit.js
• npm: https://www.npmjs.com/package/octokit

import { App } from "https://esm.sh/octokit"

Error message

from a blank directory:

$ deno run -A -r https://esm.sh init
$ deno task esm:add octokit

make test.ts with the following contents:

import { App } from "https://esm.sh/octokit"

After running deno check test.ts I got this:

error: Failed resolving types. Relative import path "@octokit/core/types" not prefixed with / or ./ or ../ and not in import map from "https://esm.sh/v135/[email protected]/X-ZS8q/dist-types/octokit.d.ts"
    at https://esm.sh/v135/[email protected]/X-ZS8q/dist-types/octokit.d.ts:4:59

Additional info

• esm.sh version: v135
• Deno version: v2.0.6

[ThisGuyCodes]

at first I thought this might be an octokit issue (I had found something else already). I opened an issue there first and they showed the mapping exists.

[wolfy1339]

This issue was already fixed in @octokit/app
octokit/app.js#583

[wolfy1339]

I'm thinking you meant the other issue, where it can't resolve @octokit/core/types

$ deno check *.ts **/*.ts --allow-import
error: Failed resolving types. Relative import path "@octokit/core/types" not prefixed with / or ./ or ../ and not in import map from "https://esm.sh/v135/[email protected]/X-ZS8q/dist-types/octokit.d.ts"
    at https://esm.sh/v135/[email protected]/X-ZS8q/dist-types/octokit.d.ts:4:59

Which has to do with exports map, and a type only import

[ThisGuyCodes]

@wolfy1339 yes. I linked to both issues. I pasted the wrong logs here.

[ThisGuyCodes]

@wolfy1339 although idk why but https://esm.sh/octokit still seems to be resolving to the older version of @octokit/app

[ije]

i will look into it

[ije]

seems it's the type checking changed in deno 2, deno 1.x works fine

[ije]

related to denoland/deno#25762

[wolfy1339]

That particular issue was resolved, it was a bug in the package. Can you please update @octokit/app on esm.sh

You need to force it to use @octokit/[email protected] in order to actually experience the issue described here