From 13aeb72e43fff746931993bab13fb75b0b3cad3d Mon Sep 17 00:00:00 2001 From: Elizabeth Santorella Date: Wed, 18 Dec 2024 15:14:22 -0800 Subject: [PATCH] Several minor benchmarking changes (#3196) Summary: This diff * Changes some Pandas indexing to avoid a "setting with copy" warning * Corrects the docstring of `BenchmarkTrialMetadata` * Renames `ModelLauncherProblem` to `ModelLauncherTestFunction`, since it is a test function and not a problem Differential Revision: D67419032 --- ax/benchmark/benchmark_metric.py | 2 +- ax/benchmark/benchmark_trial_metadata.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/ax/benchmark/benchmark_metric.py b/ax/benchmark/benchmark_metric.py index e2b560894af..0cf87127128 100644 --- a/ax/benchmark/benchmark_metric.py +++ b/ax/benchmark/benchmark_metric.py @@ -198,7 +198,7 @@ def fetch_trial_data(self, trial: BaseTrial, **kwargs: Any) -> MetricFetchResult available_data = df[df["virtual runtime"] <= max_t] if not self.observe_noise_sd: - available_data["sem"] = None + available_data.loc[:, "sem"] = None return self._df_to_result(df=available_data.drop(columns=["virtual runtime"])) @abstractmethod diff --git a/ax/benchmark/benchmark_trial_metadata.py b/ax/benchmark/benchmark_trial_metadata.py index 3628f65973c..52b3db216d7 100644 --- a/ax/benchmark/benchmark_trial_metadata.py +++ b/ax/benchmark/benchmark_trial_metadata.py @@ -20,7 +20,7 @@ class BenchmarkTrialMetadata: Args: df: A dict mapping each metric name to a Pandas DataFrame with columns - ["metric_name", "arm_name", "mean", "sem", and "t"]. The "sem" is + ["metric_name", "arm_name", "mean", "sem", and "step"]. The "sem" is always present in this df even if noise levels are unobserved; ``BenchmarkMetric`` and ``BenchmarkMapMetric`` hide that data if it should not be observed, and ``BenchmarkMapMetric``s drop data from