Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace is-ci with ci-info.isCI #128

Open
TheDevMinerTV opened this issue Oct 31, 2024 · 4 comments
Open

Replace is-ci with ci-info.isCI #128

TheDevMinerTV opened this issue Oct 31, 2024 · 4 comments

Comments

@TheDevMinerTV
Copy link

is-ci is literally just an export wrapper for ci-info's isCI field, so we can just replace it everywhere we see it. That'd save 3KB and 2 HTTP roundtrips during installation.

@TheDevMinerTV
Copy link
Author

TheDevMinerTV commented Oct 31, 2024

Replaced it in Cypress: cypress-io/cypress#30465
Edit: got merged 🎉

@TheDevMinerTV
Copy link
Author

TheDevMinerTV commented Nov 18, 2024

Replaced it in html-minifier-terser: terser/html-minifier-terser#189

@Fuzzyma
Copy link

Fuzzyma commented Nov 18, 2024

Here is a list of the top 20 packages using is-ci according to npm.js (which does not contain all dependents because it only allows the first 396 to be crawled):

Stats are downloads last-month.

# Downloads Traffic Package
1 5.25M 11.28 GB lerna
2 5.15M 11.08 GB @lerna/create
3 2.08M 4.47 GB update-notifier-cjs
4 2.07M 4.46 GB yorkie
5 2.03M 4.37 GB @lerna/command
6 1.43M 3.08 GB builder-util
7 1.43M 3.07 GB yurnalist
8 1.39M 2.99 GB app-builder-lib
9 1.32M 2.85 GB electron-builder
10 1.29M 2.77 GB npm-check
11 908.76k 1.95 GB testcafe
12 709.21k 1.52 GB @aws-amplify/platform-core
13 612.93k 1.32 GB @lerna/legacy-package-management
14 234.66k 504.53 MB @aws-amplify/graphql-api-construct
15 224.21k 482.05 MB @aws-amplify/data-construct
16 214.74k 461.70 MB @aws-amplify/backend-cli
17 174.72k 375.64 MB is-ci-cli
18 106.89k 229.81 MB hint
19 102.37k 220.10 MB @hint/connector-puppeteer
20 94.58k 203.35 MB @prisma/sdk

@43081j
Copy link
Collaborator

43081j commented Nov 19, 2024

update-notifier-cjs looks like it has these we can replace:

  • chalk
  • is-ci
  • strip-ansi

Could be a good couple of PRs!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants