Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keep only filename as id in DocCollection #17

Open
erwanm opened this issue Nov 7, 2017 · 0 comments
Open

keep only filename as id in DocCollection #17

erwanm opened this issue Nov 7, 2017 · 0 comments

Comments

@erwanm
Copy link
Owner

erwanm commented Nov 7, 2017

issue migrated from original private gitlab repo

  • In the standard case of loading from a directory with createDatasetsFromParams, the path is useless.
  • Additionally, when storing the id in pre-sim values files (in Impostors verif method), the full path is stored, which would cause problems if the file is later read from a different directory.
  • However there might be cases where it's necessary to keep the full path, I'm not sure. In this case maybe the path should be removed locally when saving pre-sim values, and re-added locally when loading the same file (i.e. it still works if the path changes between saving and loading)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant