New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove polygon/bor/finality package #12855

Open

taratorio opened this issue Nov 24, 2024 · 0 comments

Labels

astrid

Milestone

astrid-m5-cleanup

Member

taratorio commented Nov 24, 2024 •

edited

Loading

finality service is no longer needed after Astrid standalone is released

we use milestones in our chain tip mode sync algorithm
we no longer need it in the RPCs for getting finalised blocks (check rpchelper._GetBlockNumber) because we can use the existing logic for ethereum which is to use GetFinalizedBlockNumber which uses ReadForkchoiceFinalized (no changes needed for this, already happening)

Goal of this task is to completely remove all code in polygon/bor/finality package

The text was updated successfully, but these errors were encountered:

taratorio added this to the astrid-m5-cleanup milestone

yperbasis added the astrid label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment