Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global settings is useless #1

Open
yellowko opened this issue Apr 22, 2019 · 3 comments
Open

Global settings is useless #1

yellowko opened this issue Apr 22, 2019 · 3 comments

Comments

@yellowko
Copy link

The local settings and the internal settings are usable, but the global settings of this extension is useless.
When I checked your code, I found these in /vscode-verilogformar/src/extension.ts line 17.

const globalSettings = <string>vscode.workspace.getConfiguration().get('verilog-format.settings');

But when I fill my path of .verilog-format.properties in File > Preferences > Settings > Verilog Format > Settings, It will generate some codes in setting.json like these:

"verilog-format.setting": "XXX\\.verilog-format.properties",

Then I checked vscode-verilogformar/package.json line 31:

"verilog-format.setting": {

It is clear that verilog-format.setting can not match with verilog-format.settings, so that the extension can't get the path of global settings.
Users can modify verilog-format.setting to verilog-format.settings to solve the problem before the error fixed.

@Lenv12138
Copy link

Sir,thanks for your help, may I ask you in which file should i modify verilog-format.setting to verilog-format.setting? Is that in package.json? But I have already changed that, it is still not work.

@yellowko
Copy link
Author

yellowko commented Sep 16, 2021

You should confirm whether you have done the following

  1. Install JRE 1.7.0-1.8.0
  2. Install verilog-format mentioned in the README.md
  3. Create a configuration file .verilog-format.properties
  4. set the path correctly in settings.json, for example
"verilog-format.settings": "E:\\.verilog-format.properties",
"verilog-format.path": "E:\\verilog-format.exe",

@jelin-sh
Copy link

jelin-sh commented Mar 3, 2022

nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants