Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrading pandas, matplotlib, networkx packages when installing nxviz #655

Closed
PyMap opened this issue Mar 10, 2021 · 4 comments
Closed

Comments

@PyMap
Copy link

PyMap commented Mar 10, 2021

  • nxviz version: 0.6.2
  • Python version: 3.7
  • Operating System: Ubuntu 20.1

Description

While insalling nxviz from pip without specifying the version, pandas downgrade to 0.25.1, numpy to 1.17.1, matplotlib to 3.1.1 and networkx to 2.3. Versions I was using before nxviz installation were 1.2.3 (pandas), 1.20.1 (numpy), 3.3.4 (matplotlib), 2.5. (networkx).

I saw in the git repo that latest release is 0.4.0 and none of the versions I'm listing above are in the requirements.txt so I'm a bit confused from where this packages are being installed (maybe on 0.6.2 the requirements.txt specify those versions, not sure).

Just want to know if there is some update planned to install the package.

Thanks!

@ericmjl
Copy link
Owner

ericmjl commented Mar 11, 2021

Hello @PyMap! Thank you for the catch. It seems like I need to cut a new release. My long paternity leave break is coming next week, which is when I'll have a bit of time to do a new release with updated dependency versions. I think what I need to do is to pin the package versions to a minimum version rather than an exact version, while also disabling pyup.io (which insists on pinning).

@PyMap
Copy link
Author

PyMap commented Mar 11, 2021

Hi @ericmjl ! Thanks in advance for you answer. I realized this versioning stuff because I've installed OSMnx in my virtual environment (venv, not working with conda currently) and it seems that during the installation of nxviz when pandas, numpy, matplotlib and networkx are downgraded OSMNx package returns a warning with the required versions of these packages.

ERROR: osmnx 1.0.1 has requirement matplotlib>=3.3, but you'll have matplotlib 3.1.1 which is incompatible.
ERROR: osmnx 1.0.1 has requirement networkx>=2.5, but you'll have networkx 2.1 which is incompatible.

Matplotlib, for example, should be higher than 3.1 because of cb.iterable(width) deprecation.

/home/federico/federico/MDG/venv/lib/python3.7/site-packages/networkx/drawing/nx_pylab.py:563: MatplotlibDeprecationWarning: 
The iterable function was deprecated in Matplotlib 3.1 and will be removed in 3.3. Use np.iterable instead.
  if not cb.iterable(width):
/home/federico/federico/MDG/venv/lib/python3.7/site-packages/networkx/drawing/nx_pylab.py:611: MatplotlibDeprecationWarning: 
The is_numlike function was deprecated in Matplotlib 3.0 and will be removed in 3.2. Use isinstance(..., numbers.Number) instead.
  if cb.is_numlike(alpha):

Anyway, in this PR the versions I'm listing seem to be correctly updated. Not really sure.
Do you plan to disable pyup from here? Or you are working with a token for custom configuration or something? This is a related issue that can help

If it is something I can try by branching from master please let me know and I can try to give it hand with the requirements versioning.

Thanks and enjoy your time off!

@ericmjl
Copy link
Owner

ericmjl commented Mar 21, 2021

@PyMap thanks a ton for offering to help! I realize I let the ball drop for too long. I'm going to cut a new release, this time with minimum versions instead of exact versions. I also changed pyup's behaviour to avoid pinning in the future. A new release is coming shortly. Hopefully this all works well!

@PyMap
Copy link
Author

PyMap commented Mar 22, 2021

@ericmjl thanks for the fix! I reinstalled and none of the libraries I mentioned above are downgraded. So I think we can close the issue for now ...

@ericmjl ericmjl closed this as completed Mar 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants