Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand FQCN does not work properly on multi-selection #28

Open
cerbero90 opened this issue Mar 19, 2015 · 2 comments
Open

Expand FQCN does not work properly on multi-selection #28

cerbero90 opened this issue Mar 19, 2015 · 2 comments

Comments

@cerbero90
Copy link

Hi Richard and thank you very much for this great package :)

I noticed that the expand_fqcn command does not work as expected when I perform a multi-selection of a given class.

In that case, only the first occurrence gets the FQCN, the other ones remain unchanged.

Here is an example, as you can see the command works only for the first occurrence (the first comment):

fqcn_mini

@erichard
Copy link
Owner

Interesting use case, thanks for sharing it. Not so trivial as there are many possibles strategies :

  • Call the expand FQCN command on each selection. In that case you could select different classes and expand them. The problem is that you could have the quick search that open on each selection
  • Trust the user and consider that all selection are the same and perform the replace no matter what
  • Don't trust the user and filter the selection that match the first occurence and replace all same occurence

What is your opinion ?

@cerbero90
Copy link
Author

I think it would be fantastic a mix of the options 1 and 3: for each different selection ask which class should be expanded and expand all the same occurrences.

What do you think? Excessive?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants