Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalize layout and make it consistent within webviz-subsurface #660

Open
3 tasks
anders-kiaer opened this issue Jun 6, 2021 · 3 comments
Open
3 tasks
Assignees

Comments

@anders-kiaer
Copy link
Collaborator

anders-kiaer commented Jun 6, 2021

There are designs/layout/utility functions that probably should be generalized and e.g. offered through webviz-core-components and/or as common utility functions in webviz-subsurface / webviz-config package?

Tasks:

  • Detect common design patterns/utilities that should be reusable.
  • Move them to a common place (e.g. webviz-core-components and/or webviz-subsurface and/or webviz-config).
  • Make layout more consistent throughout webviz-subsurface by reusing the same code.

See:

@asnyv
Copy link
Collaborator

asnyv commented Jun 7, 2021

We should at the same time take a look at how we can optimize space usage and how "friendly" the Webviz plugins/figures are for direct use in e.g. presentations and reports 😊

With this I mean things like:

  • Whether we can standardize, and often cut, borders/spacing between elements
  • Consider to remove shadowing. Why: Shadows adds some "visual noise", especially when cropping figures for presentations/reports, plus that they take up space that could be used for plots and figures
  • Standardize size and bold/not bold for selectors, headers, titles, axes and etc (more aesthetically pleasing in reports if the plots follow as similar formatting as possible.
  • A way to maximize plots if the view consists of multiple subplots
  • Try to avoid different background colors, especially surrounding plots. Not a big problem in webviz itself, but you usually don't want variations in background colors if you e.g. use Webviz to generate figures for presentations and reports (similar to shadows)

@HansKallekleiv
Copy link
Collaborator

HansKallekleiv commented Jun 8, 2021

One suggestion is to:

  • Create a few layout components in webviz-core-components to reduce code and standardize layout with regards to colors, fonts and e.g. border styling.
  • Add a "print mode" button to the plugin wrapper toolbar that removes some of the styling, e.g. borders/shadows of the layout components. Should be easy to implement on the React side, some initial testing here: Styled div wrapper and ThemeContext webviz-core-components#143

@HansKallekleiv HansKallekleiv mentioned this issue Jun 9, 2021
6 tasks
@anders-kiaer
Copy link
Collaborator Author

The main part of this issue is now solved by #667 as I see it. I'm suggesting closing this and move the remaining ideas to separate issues:

  • Print mode (remove shadows, borders...)
  • Maximize parts/frames of a plugin.

I can do this if no objections 🙂

@anders-kiaer anders-kiaer moved this to Backlog 📝 in Webviz Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Backlog 📝
Development

No branches or pull requests

4 participants