Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag optional or not? #360

Open
smolvik1 opened this issue Jun 19, 2024 · 2 comments
Open

Tag optional or not? #360

smolvik1 opened this issue Jun 19, 2024 · 2 comments

Comments

@smolvik1
Copy link

Perhaps a silly question, but is tag an Optional parameter in search as per the type hinting or not?

@smolvik1
Copy link
Author

smolvik1 commented Jun 19, 2024

c = tagreader.IMSClient("GFB", "aspenone") c.connect() c.search(desc='*Ringrom*')

Yields Tag is required.

Doing the same for a piwebapi client, e.g PINO, results are returned. Assuming then that the aspenone client requires the tag input when searching, whereas the piwebapi client does not.

@Asgmel03
Copy link
Contributor

I apologize for the late answer. Tagreader has been on the back-burner for a while as we have been tasked on different projects. Yes this is because Aspenone client requires the input tag when searching while the piwebapi does not. But I see that the typing is a bit confusing and I'll look into if we can find a better way to do it so that we don't get conflicting types.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants