Skip to content

Commit

Permalink
hotfix: reference check navigation module and ag-grid module. (#2442)
Browse files Browse the repository at this point in the history
  • Loading branch information
odinr authored Sep 5, 2024
1 parent d10e81e commit 80cc4e9
Show file tree
Hide file tree
Showing 4 changed files with 18 additions and 4 deletions.
8 changes: 8 additions & 0 deletions .changeset/hip-mugs-begin.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
---
'@equinor/fusion-framework-module-navigation': patch
'@equinor/fusion-framework-module-ag-grid': patch
---

Fixed reference check in navigation module and ag-grid module.

hotfix for [PR-2425](https://github.com/equinor/fusion-framework/pull/2425)
6 changes: 6 additions & 0 deletions packages/cli/vite.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -13,5 +13,11 @@ export default defineConfig({
build: {
outDir: fileURLToPath(new URL('./dist/bin/public', import.meta.url)),
emptyOutDir: true,
// TODO: keep for debug purposes
// minify: false,
// terserOptions: {
// mangle: false,
// compress: false,
// },
},
});
2 changes: 1 addition & 1 deletion packages/modules/ag-grid/src/module.ts
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ export type AgGridModule = Module<'agGrid', IAgGridProvider, IAgGridConfigurator

export const module: AgGridModule = {
name: 'agGrid',
configure: (ref: ModulesInstanceType<[AgGridModule]>) => {
configure: (ref?: ModulesInstanceType<[AgGridModule]>) => {
const config = new AgGridConfigurator();
if (ref?.agGrid) {
config.licenseKey = ref.agGrid.licenseKey;
Expand Down
6 changes: 3 additions & 3 deletions packages/modules/navigation/src/module.ts
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,10 @@ export type NavigationModule = Module<
export const module: NavigationModule = {
version: new SemanticVersion(version),
name: moduleKey,
configure: (ref?: unknown) => {
configure: (ref?: ModuleInstance) => {
const configurator = new NavigationConfigurator();
if (ref) {
configurator.history = (ref as ModuleInstance).navigation.navigator;
if (ref?.navigation) {
configurator.history = ref.navigation.navigator;
}
return configurator;
},
Expand Down

0 comments on commit 80cc4e9

Please sign in to comment.