Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schema versioning: Give the fmu_results.json schema a better title #908

Open
mferrera opened this issue Dec 10, 2024 · 2 comments
Open

Schema versioning: Give the fmu_results.json schema a better title #908

mferrera opened this issue Dec 10, 2024 · 2 comments

Comments

@mferrera
Copy link
Collaborator

Since we dump the schema from a Root Pydantic model we define, the schema is given that as its title:

"title": "Root"
}

It's a minor and relatively inconsequential change, but we can give it a more meaningful title by setting it directly here:

json_schema["$schema"] = self.schema_dialect
json_schema["$id"] = "fmu_results.json"
json_schema["$contractual"] = self.contractual

@perolavsvendsen
Copy link
Member

Just to clarify: Filename on the endpoint remains the same? If not, that change needs to be coordinated 😬

@mferrera
Copy link
Collaborator Author

The filename remains the same, the title will just end up a human readable version of it like "FMU Results"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants