Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for multiple occurrences of design matrix #9583

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Add support for multiple occurrences of design matrix #9583

wants to merge 7 commits into from
+254 −42

Conversation

xjules
Copy link
Contributor

@xjules xjules commented Dec 18, 2024

Issue
Resolves #9532

Approach
todo

(Screenshot of new behavior in GUI if applicable)

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@xjules xjules self-assigned this Dec 18, 2024
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Dec 18, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #9583 will improve performances by 10.61%

Comparing xjules:mult_dm (2d94476) with main (9ba5a28)

Summary

⚡ 1 improvements
✅ 23 untouched benchmarks

Benchmarks breakdown

Benchmark main xjules:mult_dm Change
⚡ test_direct_dark_performance_with_storage[gen_x: 20, sum_x: 20 reals: 10-gen_data-get_record_observations] 1.6 ms 1.4 ms +10.61%

@codecov-commenter
Copy link

codecov-commenter commented Dec 19, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 81.48148% with 5 lines in your changes missing coverage. Please review.

Project coverage is 91.88%. Comparing base (01156bb) to head (6c7240e).
Report is 16 commits behind head on main.

Files with missing lines Patch % Lines
src/ert/config/design_matrix.py 75.00% 5 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #9583      +/-   ##
==========================================
+ Coverage   91.85%   91.88%   +0.02%     
==========================================
  Files         433      433              
  Lines       26768    26804      +36     
==========================================
+ Hits        24587    24628      +41     
+ Misses       2181     2176       -5
Flag Coverage Δ
cli-tests 39.79% <81.48%> (+0.03%) ⬆️
everest-models-test 34.55% <18.51%> (-0.04%) ⬇️
gui-tests 72.11% <18.51%> (-0.01%) ⬇️
integration-test 37.18% <18.51%> (-0.02%) ⬇️
performance-tests 52.01% <18.51%> (+0.07%) ⬆️
test 40.65% <18.51%> (+0.20%) ⬆️
unit-tests 74.12% <25.92%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@larsevj larsevj self-requested a review December 20, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@larsevj larsevj Awaiting requested review from larsevj

At least 1 approving review is required to merge this pull request.

Assignees

@xjules xjules

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for multiple instances of DESIGN_MATRIX in the config
2 participants
@xjules @codecov-commenter