Add event serialization testing #9573
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9573 +/- ##
==========================================
- Coverage 91.87% 91.84% -0.04%
==========================================
Files 433 433
Lines 26770 26770
==========================================
- Hits 24595 24586 -9
- Misses 2175 2184 +9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
CodSpeed Performance ReportMerging #9573 will improve performances by 11.06%Comparing Summary
Benchmarks breakdown
|
DanSava
force-pushed
the
test-event-serialization
branch
from
261b703 to
bdac9c6
Compare
oyvindeide
reviewed
Dec 18, 2024
| event, _ = args | ||
| event_json = event_to_json(event) | ||
| round_trip_event = event_from_json(str(event_json)) | ||
| assert event == round_trip_event |
There was a problem hiding this comment.
In this case, if we get a FullSnapshotEvent or a SnapshotUpdateEvent, are we able to differentiate them?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Resolves #9517
Approach
Add serialization roundtrip for all events generated by EverestRunModel
git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')When applicable