From 9823e69c7a28e282c725b3f3f8cd6dd290fc57dd Mon Sep 17 00:00:00 2001
From: VarunVAshrit <159520405+VarunVAshrit@users.noreply.github.com>
Date: Thu, 21 Nov 2024 17:10:41 +0530
Subject: [PATCH] =?UTF-8?q?:label:=20Update=20text=20snippets=20and=20fix?=
 =?UTF-8?q?=20pension=20form=20translation=20issue=20#=E2=80=A6=20(#2686)?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

* :label: Update text snippets and fix pension form translation issue #2681

* Added Asterisk in label
---
 sanityv3/schemas/textSnippets.ts              | 20 +++++--------------
 .../topicPages/Form/CareerFairForm.tsx        |  6 +++---
 .../topicPages/Form/PensionForm.tsx           | 10 +++++-----
 .../careersContactForm/CareersContactForm.tsx |  6 +++---
 4 files changed, 16 insertions(+), 26 deletions(-)

diff --git a/sanityv3/schemas/textSnippets.ts b/sanityv3/schemas/textSnippets.ts
index 487c333d7..8c7f0338a 100644
--- a/sanityv3/schemas/textSnippets.ts
+++ b/sanityv3/schemas/textSnippets.ts
@@ -163,11 +163,6 @@ const snippets: textSnippet = {
     defaultValue: 'Please choose one or more of the following',
     group: groups.subscribeForm,
   },
-  subscribe_form_email: {
-    title: 'Email',
-    defaultValue: 'Email',
-    group: groups.subscribeForm,
-  },
   subscribe_form_general_news: {
     title: 'General News',
     defaultValue: 'General News',
@@ -241,11 +236,6 @@ const snippets: textSnippet = {
       'Want the full picture? We’d love to share this content with you, but first you must accept {type1}, {type2} and {type3} cookies by enabling them in our cookie settings.',
     group: groups.cookie,
   },
-  contact_form_email: {
-    title: 'Email',
-    defaultValue: 'Email *',
-    group: groups.contactForm,
-  },
   contact_form_category: {
     title: 'Category',
     defaultValue: 'Category',
@@ -305,6 +295,11 @@ const snippets: textSnippet = {
     title: 'Pension Category',
     defaultValue: 'Pension',
     group: groups.pensionForm,
+  }, 
+  pension_form_select_topic: {
+    title: 'Default Pension Category',
+    defaultValue: 'Pension',
+    group: groups.pensionForm,
   },
   pension_form_category_travel_insurance: {
     title: 'Travel Insurance Category',
@@ -367,11 +362,6 @@ const snippets: textSnippet = {
     defaultValue: 'Please enter your phone number',
     group: groups.careerFairForm,
   },
-  career_fair_form_email: {
-    title: 'Email',
-    defaultValue: 'Email',
-    group: groups.careerFairForm,
-  },
   career_fair_form_event: {
     title: 'Event',
     defaultValue: 'Event',
diff --git a/web/pageComponents/topicPages/Form/CareerFairForm.tsx b/web/pageComponents/topicPages/Form/CareerFairForm.tsx
index bde94b27a..140833009 100644
--- a/web/pageComponents/topicPages/Form/CareerFairForm.tsx
+++ b/web/pageComponents/topicPages/Form/CareerFairForm.tsx
@@ -207,10 +207,10 @@ const CareerFairForm = () => {
                 <FormTextField
                   {...props}
                   id={props.name}
-                  label={intl.formatMessage({
-                    id: 'career_fair_form_email',
+                  label={`${intl.formatMessage({
+                    id: 'email',
                     defaultMessage: 'Email',
-                  })}
+                  })}*`}
                   inputRef={ref}
                   inputIcon={invalid ? <Icon data={error_filled} title="error" /> : undefined}
                   helperText={error?.message}
diff --git a/web/pageComponents/topicPages/Form/PensionForm.tsx b/web/pageComponents/topicPages/Form/PensionForm.tsx
index efe53eed0..d9919044c 100644
--- a/web/pageComponents/topicPages/Form/PensionForm.tsx
+++ b/web/pageComponents/topicPages/Form/PensionForm.tsx
@@ -144,7 +144,7 @@ const PensionForm = () => {
                 pattern: {
                   value: /^[\w!#$%&'*+/=?`{|}~^-]+(?:\.[\w!#$%&'*+/=?`{|}~^-]+)*@(?:[a-zA-Z0-9-]+\.)+[a-zA-Z]{2,6}$/g,
                   message: intl.formatMessage({
-                    id: 'pension_form_email_validation',
+                    id: 'email_validation',
                     defaultMessage: 'Please fill out a valid email address',
                   }),
                 },
@@ -188,14 +188,14 @@ const PensionForm = () => {
                       {intl.formatMessage({ id: 'pension_form_select_topic', defaultMessage: 'Select topic' })}
                     </option>
                     <option value="pension">
-                      {intl.formatMessage({ id: 'pension_form_pension', defaultMessage: 'Pension' })}
+                      {intl.formatMessage({ id: 'pension_form_category_pension', defaultMessage: 'Pension' })}
                     </option>
                     <option value="travelInsurance">
-                      {intl.formatMessage({ id: 'pension_form_travel_insurance', defaultMessage: 'Travel Insurance' })}
+                      {intl.formatMessage({ id: 'pension_form_category_travel_insurance', defaultMessage: 'Travel Insurance' })}
                     </option>
                     <option value="otherPensionInsuranceRelated">
                       {intl.formatMessage({
-                        id: 'pension_form_other_pension_insurance_related',
+                        id: 'pension_form_category_other',
                         defaultMessage: 'Other Pension/Insurance Related',
                       })}
                     </option>
@@ -262,7 +262,7 @@ const PensionForm = () => {
               {isSubmitting ? (
                 <FormattedMessage id="form_sending" defaultMessage={'Sending...'}></FormattedMessage>
               ) : (
-                <FormattedMessage id="pension_form_cta" defaultMessage="Submit Form" />
+                <FormattedMessage id="pension_form_submit" defaultMessage="Submit Form" />
               )}
             </Button>
           </>
diff --git a/web/pageComponents/topicPages/Form/careersContactForm/CareersContactForm.tsx b/web/pageComponents/topicPages/Form/careersContactForm/CareersContactForm.tsx
index 4a97dd5e5..d6d36749c 100644
--- a/web/pageComponents/topicPages/Form/careersContactForm/CareersContactForm.tsx
+++ b/web/pageComponents/topicPages/Form/careersContactForm/CareersContactForm.tsx
@@ -184,10 +184,10 @@ const CareersContactForm = () => {
                 <FormTextField
                   {...props}
                   id={props.name}
-                  label={intl.formatMessage({
-                    id: 'careers_contact_form_email',
+                  label={`${intl.formatMessage({
+                    id: 'email',
                     defaultMessage: 'Email',
-                  })}
+                  })}*`}
                   inputRef={ref}
                   inputIcon={invalid ? <Icon data={error_filled} title="error" /> : undefined}
                   helperText={error?.message}