-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop iSoQ from deleting explanation text when user selects a different assessment #222
Comments
@damian-garrido Simon raised this as an issue again. I'm going to make it a priority |
hi @MJWainwright Screencast.from.2024-03-20.10-25-56.webm |
@damian-garrido I'm going to check with Simon to see what he thinks as this was an issue he raised. I'm a little concerned that users will start free writing in that box rather than realising they have to complete the sentence. Then they will only realise this is what happens when they save and see that the text "minor concerns regarding..." has been added to the start of their text. But let me check with Simon and I'll get back to you soon. Thanks! |
@MJWainwright |
@damian-garrido . I got some feedback from Simon, Claire and another user about this. Firstly, we want the user to complete the sentence "X concerns regarding X because...". So we would want that text added automatically to whatever the user enters into the box once they have clicked save. However, we think that users may not know that this text will be added and might write an explanation which then doesn't make sense when "X concersn regarding X because..." is added to the start. Also, if it is added automatically then people cannot remove it, whereas right now they could simply delete the text "x concerns regarding X because" and write whatever they want. So the questions are:
If there is no way around this then the feedback so far is that it is more annoying for the users to loose the explanation they enter when they change level of concern, then it would be to find out only after saving that "x concerns regarding x because..." will be added to to the start of their explanation. |
@MJWainwright what do you think if we explain that the gray content "X concerns regarding X because..." will be displayed on the final document, the exportable document, so, the user will be write in the textarea whatever they need, also, could change the selector, but when they export this, the gray text will be prepended to the text that the user introduce in the textarea. |
@damian-garrido, i don't think this solves the issue. We want that pre-text to appear not just in the exported document but in the online Evidence Profile. So whatever the user enters into the box, the text "minor concerns regarding methodological limitations because" is added to the start of the text and appears in the Evidence Profile table. The user will quickly learn that this text is added, and adjust accordingly. They will not be able to delete it, so we may get some complaints about that, but let's gather some user feedback. I think it's the best we can do for now. Please delete the sentence "Explain any concerns in your own words" and replace with "Select a level of concern above and complete the sentence that appears below to explain your concerns (not required for no/very minor concerns)": Make the automated text "X concerns with X because" bold, remove the "...." at the end of the sentence and make the text size the same as the text size in the explanation box. |
@damian-garrido Any update on this one? |
@MJWainwright Screencast.from.2024-08-28.09-38-09.mp4as you can see, now the text related to the options is displayed above the textarea and don't delete the text that the user put in when you change your option. but also, i have a doubt related to the GRADE-CERQual assessment of confidence, in this section, the text should be displayed as the other? for the moment i don't display nothing as you can see in the following video Screencast.from.2024-08-28.09-44-42.mp4let me know anything! |
@MJWainwright could you check this? |
@damian-garrido Apologies all my iSoQ time was put towards preparing for the webinar at the end of the month. I'm now going to be off work for 2 weeks. @javierapena could you check the update Damián has made and provide feedback to him please? I will check when I return as well. Thanks! |
Hi Megan! |
@damian-garrido I do not see the change you showed me yesterday on the test server. I cleared my cache. It just looks exactly like it did before (a notes box, and an explanation box that appears only when you make a selection and has the starting text in the box rather than above it) |
@MJWainwright sorry! |
@MJWainwright i found an issue related to the new approach for the preventing delete content. |
@damian-garrido I discovered an issue. The start of the sentence in bold is missing when the user selects no/very minor concerns. (see below). The text "No/very minor concerns regarding methodological limitations because" needs to appear above the box. HOWEVER, for no/very minor the explanation is optional, so if the user does not enter any text in the box then the text "no/very minor concerns regarding methodological limitations because..." should NOT appear in the evidence profile when the user clikcs save. |
@damian-garrido Another error is that the warning text "it looks like you have not finished writing an explanation" modal appears when the user selects no/very minor. This is incorrect. As an explanation is not required for "No/very minor" this modal should not appear if the user does not write an explanation. Look at the production server, it is correct there. |
@damian-garrido Another thing that is on the production server and is now missing on the test server is the minimum text in the explanation. This should be populated automatically in the box. See the problem in the test server in the first image, and then see the correct functionality in the production server in the second photo |
@damian-garrido We need the pre-populated minimum explanation in the overall assessment and this should automatically update if the user selects a different option in one of the four component assessment modals. Can you do this for the overall assessment modal but keep the other 4 as you've done them (with the explanation text "holding")? |
- Update the description for the select-project-list-status form group in organizationForm.vue to include additional requirements for publishing to the iSoQ database. - Update the error message in actionButtons.vue to display HTML content. - Remove commented out code in project.js. Fixes #169, #270, #222, #271
@MJWainwright i made the changes for bringing back the pre-populated explanation for the cerqual, also remove the modal for require an explanation in case you select "No/very minor concerns", also "No/very minor concerns" appears in bold now. |
@damian-garrido But, the issue is, and perhaps that's been this way and we've not seen it before, but if the user completes all 4 assessments and then completes the overall assessment, and then goes back to one of the components and chnages an assessment, the overall assessment explanation text remains the same and is in fact incorrect (e,g, if at first I selected minor concerns for coherence, do the overall assessment, then co back to coherence and change to serious concerns, the pre-populated text in the explanation for the overall assessment still says "minor concerns". So this is a problem. I'm thinking that if a user changes a component assessment, then they should have to redo their overall assessment, so perhaps the action of changing a level of concern for any of the components should delete the overall assessment and revert back to that column saying "assessment not completed". But the trade-off is that the user will loose any of the content they added to the prepopulated explanation, and would loose the content they've written into the notes box. Maybe we need a call to discuss this. |
Hi @MJWainwright! Damian is out of the office this week. |
@javierapena . Thanks Javiera! Let's see what Damián says when he is back. |
@MJWainwright @javierapena |
@damian-garrido are you sayin git is not possible for iSoQ to keep the content in the Notes box but wipe the rest of the content (overall assessment and explanation)? |
@MJWainwright no, actually it's possible to keep the whole content. (selected option, explanation and notes) |
@damian-garrido . Sorry I'm not understanding you. Maybe we have a quick meeting about this. I'll email you. |
@MJWainwright sure, today i could, also tomorrow. |
@damian-garrido Tomorrow would be great |
@damian-garrido Thanks for the call. So the decision was when the user has completed the GRADE-CERqual assessment of Confidence but then goes back to a component assessment and changes the level of concern (radio buttons), then a pop-up warning needs to appear that says Warning If the user selects No, nothing happens and their change is not saved |
@MJWainwright i have an update of this |
A user has reported that it is quite annoying that all the text you type into the Explanation box is lost if you change your mind and select a different radio button. Can we please make it so that the text the user enters remains in the explanation box even if they change their selection in the radio buttons?
You can see this by doing the following:
= the explanation disappears and the user has to retype it. we expect it to be fairly common that as a user writes out an explanation they may decide to change their rating in this way so it would be great if the text entered into the explanation box is saved.
The text was updated successfully, but these errors were encountered: