Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace custom post type with something more lightweight #194

Open
1 task done
MatzeKitt opened this issue Aug 7, 2023 · 1 comment
Open
1 task done

Replace custom post type with something more lightweight #194

MatzeKitt opened this issue Aug 7, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@MatzeKitt
Copy link
Member

What feature are you requesting?

The custom post type for embeds is quite heavy in resource usage. Additionally, there is no benefit in using a CPT here. This should be changed to a simple option with serialized data with an easier interface for editing, while maintaining the same functionality:

  • Allow editing the title
  • Allow editing the overlay message
  • Allow editing the regular expression
  • Allow editing the privacy policy URL
  • Allow editing the background image
  • Allow editing the logo

Why is this feature necessary?

Improved performance and less data in database

Are you expecing side-effects?

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@MatzeKitt MatzeKitt added the enhancement New feature or request label Aug 7, 2023
@MatzeKitt MatzeKitt added this to the Version 2.0.0 milestone Aug 7, 2023
@MatzeKitt
Copy link
Member Author

Don’t do it this way. Check for other possibilities to limit its usage. Maybe adding a wrapper to only request data we need instead of full WP_Post objects.

However, it’s not a big issue so far, so maybe we leave it as is, for now.

@MatzeKitt MatzeKitt removed this from the Version 2.0.0 milestone Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant