Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JS-API to enable/disable embeds #186

Open
1 task done
kraftner opened this issue Jul 11, 2023 · 1 comment
Open
1 task done

Add JS-API to enable/disable embeds #186

kraftner opened this issue Jul 11, 2023 · 1 comment
Labels
enhancement New feature or request
Milestone

Comments

@kraftner
Copy link
Contributor

What feature are you requesting?

I love the fact that the plugin does one thing well in contrast to most other plugins offering embed consent that is bundled with consent banners and other functions. So you can mix and match features you need here.

The only thing that is missing for me right now is some kind of JS-API to enable/disable embeds without basically re-implementing most of the functionality in embed-privacy.js.

Something like:

window.embedPrivacy.enableProviderAlwaysActive()
window.embedPrivacy.disableProviderAlwaysActive()
window.embedPrivacy.enableAllProvidersAlwaysActive()
window.embedPrivacy.disableAllProvidersAlwaysActive()

Why is this feature necessary?

It would allow the plugin to be integrated with other 3rd party functionality, e.g. with a consent banner were you can give consent to load all embeds together with other things like tracking.

Are you expecing side-effects?

Apart from the general issue that you're opening a new API surface that needs to be maintained: No, since it doesn't change any of the existing functionality.

Code of Conduct

  • I agree to follow this project's Code of Conduct
@kraftner
Copy link
Contributor Author

This could maybe be considered in the context of #67.

@MatzeKitt MatzeKitt added the enhancement New feature or request label Jul 11, 2023
@MatzeKitt MatzeKitt added this to the Version 2.0.0 milestone Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants