From d2e7320f535827ce900ff3f356dff643f3c185c0 Mon Sep 17 00:00:00 2001
From: Daniel Couzens <dan.couzens@epimorphics.com>
Date: Mon, 12 Aug 2024 14:34:45 +0100
Subject: [PATCH 1/2] adds underline styles to feedback section

---
 CHANGELOG.md                                           | 3 ++-
 app/assets/stylesheets/lr_common_styles/_feedback.scss | 5 +++++
 2 files changed, 7 insertions(+), 1 deletion(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index cb8318e..83781fb 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -7,7 +7,8 @@ applications.
 
 ## 1.9.4 - 2024-08
 
-- (Dan) Adds underline to link to text to meet accessibility requirments [126](https://github.com/epimorphics/lr-landing/issues/126)
+- (Dan) Adds underline to link text for the feedback section to meet accessibility requirments [114](https://github.com/epimorphics/standard-reports-ui/issues/114)
+- (Dan) Adds underline to link text in the cookie banner to meet accessibility requirments [126](https://github.com/epimorphics/lr-landing/issues/126)
 
 ## 1.9.3 - 2023-11-27
 
diff --git a/app/assets/stylesheets/lr_common_styles/_feedback.scss b/app/assets/stylesheets/lr_common_styles/_feedback.scss
index b7a660a..bd73530 100644
--- a/app/assets/stylesheets/lr_common_styles/_feedback.scss
+++ b/app/assets/stylesheets/lr_common_styles/_feedback.scss
@@ -2,4 +2,9 @@
   margin-top: 2em;
   padding-top: 1em;
   border-top: 2px solid $lr-green-nav;
+  p {
+    a {
+      text-decoration: underline;
+    }
+  }
 }

From f83d6043ee6ab1ad4520c67f9705c057f8862152 Mon Sep 17 00:00:00 2001
From: Daniel Couzens <dan.couzens@epimorphics.com>
Date: Tue, 13 Aug 2024 15:24:39 +0100
Subject: [PATCH 2/2] underline adjusted to be only under feedback text

---
 .../stylesheets/lr_common_styles/_feedback.scss   | 15 +++++++++++++--
 1 file changed, 13 insertions(+), 2 deletions(-)

diff --git a/app/assets/stylesheets/lr_common_styles/_feedback.scss b/app/assets/stylesheets/lr_common_styles/_feedback.scss
index bd73530..b254f7b 100644
--- a/app/assets/stylesheets/lr_common_styles/_feedback.scss
+++ b/app/assets/stylesheets/lr_common_styles/_feedback.scss
@@ -4,7 +4,18 @@
   border-top: 2px solid $lr-green-nav;
   p {
     a {
-      text-decoration: underline;
+       text-decoration: underline;
+       
+       &[rel="external"] {
+          &:after {
+             text-decoration: none; 
+             background-position: 5px 6px;
+             display: inline-block;
+             &:hover {
+                background-position: right -385px
+             }
+          }
+       }
     }
-  }
+ }
 }